Skip to content

Conversation

@nnsense
Copy link
Contributor

@nnsense nnsense commented Aug 26, 2024

what

Implementation of the aws_lambda_event_source_mapping resource, allowing to set a Kinesis stream, DynamoDB stream, or SQS queue as a trigger for lambda. I've purposely kept things simple allowing only a few variables:

  • source_mapping_arn pointing to the arn of the triggering resource (eg, the lambda execution role)
  • source_mapping_batch_size allowing to tune the number of events we pass to the function.
  • source_mapping_starting_position, because it's usually required and terraform complains if it's unset
  • source_mapping_starting_position_timestamp, if someone wants to use AT_TIMESTAMP in Kinesis.

why

It's useful to get lambda triggered by other resources without having to set just one resource in another module.

@nnsense nnsense requested review from a team as code owners August 26, 2024 19:34
@nnsense nnsense requested review from hans-d and joe-niland August 26, 2024 19:34
@mergify mergify bot added the triage Needs triage label Aug 26, 2024
@milldr
Copy link
Member

milldr commented Aug 27, 2024

/terratest

@milldr
Copy link
Member

milldr commented Aug 27, 2024

/terratest

@milldr
Copy link
Member

milldr commented Aug 28, 2024

/terratest

@nnsense
Copy link
Contributor Author

nnsense commented Aug 28, 2024

Hi @milldr I think I've fixed the terraform/tofu testing passing a few fake parameters, let me know if that's OK and we're ready for another go :)

@milldr
Copy link
Member

milldr commented Aug 28, 2024

/terratest

@nnsense
Copy link
Contributor Author

nnsense commented Aug 28, 2024

Cloudposse Dynamo DB table module added to examples

@milldr
Copy link
Member

milldr commented Aug 28, 2024

/terratest

@milldr
Copy link
Member

milldr commented Sep 4, 2024

/terratest

@mergify
Copy link

mergify bot commented Sep 19, 2024

💥 This pull request now has conflicts. Could you fix it @nnsense? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Sep 19, 2024
@mergify mergify bot removed the conflict This PR has conflicts label Sep 25, 2024
@nnsense
Copy link
Contributor Author

nnsense commented Sep 25, 2024

Hey @milldr, if you have time, could you review again? I hope I've fixed everything, sorry for the delay.. busy days! Thanks :)

@milldr
Copy link
Member

milldr commented Sep 25, 2024

/terratest

@nnsense
Copy link
Contributor Author

nnsense commented Sep 25, 2024

Fixed (hopefully), overlloked those dots 🤦🏻‍♂️

@milldr
Copy link
Member

milldr commented Oct 7, 2024

/terratest

@mergify
Copy link

mergify bot commented May 29, 2025

💥 This pull request now has conflicts. Could you fix it @nnsense? 🙏

@mergify mergify bot added the conflict This PR has conflicts label May 29, 2025
@mergify mergify bot closed this May 29, 2025
@mergify
Copy link

mergify bot commented May 29, 2025

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed conflict This PR has conflicts triage Needs triage labels May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants