Skip to content

Fix flickering when transit gateway description is not set #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattock wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix flickering when transit gateway description is not set #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ locals {

resource "aws_ec2_transit_gateway" "default" {
count = module.this.enabled && var.create_transit_gateway ? 1 : 0
description = var.transit_gateway_description == "" ? format("%s Transit Gateway", module.this.id) : var.transit_gateway_description
description = var.transit_gateway_description == "" ? format("%sTransit Gateway", module.this.id) : var.transit_gateway_description
Copy link
Member

@Gowiem Gowiem Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = var.transit_gateway_description == "" ? format("%sTransit Gateway", module.this.id) : var.transit_gateway_description
description = var.transit_gateway_description == "" ? join(" ", compact([module.this.id, "Transit Gateway"])) : var.transit_gateway_description

auto_accept_shared_attachments = var.auto_accept_shared_attachments
default_route_table_association = var.default_route_table_association
default_route_table_propagation = var.default_route_table_propagation
Expand Down