From c9e057db3a1892065a8c97a939f25dfaf63b298d Mon Sep 17 00:00:00 2001 From: Evan Lezar Date: Wed, 10 Dec 2025 09:26:27 +0100 Subject: [PATCH 1/3] Update empty check for consistency Signed-off-by: Evan Lezar --- specs-go/version.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specs-go/version.go b/specs-go/version.go index 62be6b7..c3f5a8d 100644 --- a/specs-go/version.go +++ b/specs-go/version.go @@ -150,7 +150,7 @@ func requiresV110(spec *Spec) bool { } } - if len(spec.ContainerEdits.NetDevices) != 0 { + if len(spec.ContainerEdits.NetDevices) > 0 { return true } @@ -161,7 +161,7 @@ func requiresV110(spec *Spec) bool { } } - if len(dev.ContainerEdits.NetDevices) != 0 { + if len(dev.ContainerEdits.NetDevices) > 0 { return true } } From 35a847b49a52aaef81b380688c022430cce84f75 Mon Sep 17 00:00:00 2001 From: Evan Lezar Date: Wed, 10 Dec 2025 09:25:31 +0100 Subject: [PATCH 2/3] Bump version to v1.1.0 This change includes a CDI spec version bump to v1.1.0 as well as a bump for the associated packages. Signed-off-by: Evan Lezar --- SPEC.md | 2 +- cmd/cdi/go.mod | 4 ++-- cmd/validate/go.mod | 4 ++-- go.mod | 2 +- schema/go.mod | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/SPEC.md b/SPEC.md index a080a44..78fee33 100644 --- a/SPEC.md +++ b/SPEC.md @@ -8,7 +8,7 @@ ## Version -This is CDI **spec** version **1.0.0**. +This is CDI **spec** version **1.1.0**. ### Update policy diff --git a/cmd/cdi/go.mod b/cmd/cdi/go.mod index 4a1a59e..4994a31 100644 --- a/cmd/cdi/go.mod +++ b/cmd/cdi/go.mod @@ -9,9 +9,9 @@ require ( github.com/spf13/cobra v1.6.0 gopkg.in/yaml.v3 v3.0.1 sigs.k8s.io/yaml v1.4.0 - tags.cncf.io/container-device-interface v1.0.1 + tags.cncf.io/container-device-interface v1.1.0 tags.cncf.io/container-device-interface/schema v0.0.0 - tags.cncf.io/container-device-interface/specs-go v1.0.0 + tags.cncf.io/container-device-interface/specs-go v1.1.0 ) require ( diff --git a/cmd/validate/go.mod b/cmd/validate/go.mod index db32209..8bd5ea3 100644 --- a/cmd/validate/go.mod +++ b/cmd/validate/go.mod @@ -10,8 +10,8 @@ require ( github.com/xeipuuv/gojsonschema v1.2.0 // indirect golang.org/x/mod v0.19.0 // indirect sigs.k8s.io/yaml v1.4.0 // indirect - tags.cncf.io/container-device-interface v1.0.1 // indirect - tags.cncf.io/container-device-interface/specs-go v1.0.0 // indirect + tags.cncf.io/container-device-interface v1.1.0 // indirect + tags.cncf.io/container-device-interface/specs-go v1.1.0 // indirect ) replace ( diff --git a/go.mod b/go.mod index a09b833..9f1d07c 100644 --- a/go.mod +++ b/go.mod @@ -10,7 +10,7 @@ require ( golang.org/x/sys v0.19.0 gopkg.in/yaml.v3 v3.0.1 sigs.k8s.io/yaml v1.4.0 - tags.cncf.io/container-device-interface/specs-go v1.0.0 + tags.cncf.io/container-device-interface/specs-go v1.1.0 ) require ( diff --git a/schema/go.mod b/schema/go.mod index 0e8353a..e5370e9 100644 --- a/schema/go.mod +++ b/schema/go.mod @@ -6,8 +6,8 @@ require ( github.com/stretchr/testify v1.7.0 github.com/xeipuuv/gojsonschema v1.2.0 sigs.k8s.io/yaml v1.4.0 - tags.cncf.io/container-device-interface v1.0.1 - tags.cncf.io/container-device-interface/specs-go v1.0.0 + tags.cncf.io/container-device-interface v1.1.0 + tags.cncf.io/container-device-interface/specs-go v1.1.0 ) require ( From a18ecc21e8afe1b90ec70b587912ce8ef8cebd06 Mon Sep 17 00:00:00 2001 From: Evan Lezar Date: Wed, 10 Dec 2025 09:32:54 +0100 Subject: [PATCH 3/3] Update SPEC.md instructions in release template Signed-off-by: Evan Lezar --- .github/ISSUE_TEMPLATE/new-release.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/new-release.md b/.github/ISSUE_TEMPLATE/new-release.md index 493817d..ecc7322 100644 --- a/.github/ISSUE_TEMPLATE/new-release.md +++ b/.github/ISSUE_TEMPLATE/new-release.md @@ -22,7 +22,7 @@ it accordingly for future releases. - [ ] (*for specification changes only*) the `tags.cncf.io/container-device-interface/specs-go` version in `schema/go.mod`. - [ ] Run `make mod-tidy` to update versions in `cmd/**/go.mod`. - [ ] Run `make mod-verify` to ensure modules are up to date. - - [ ] (*for specification changes only*) Add a description to the specification changes in `SPEC.md`. + - [ ] (*for specification changes only*) Add a description to the specification changes and update the version in `SPEC.md`. - [ ] (*for specification changes only*) Implement a `requiresV*` function for the target version in `specs-go/versions.go`. - [ ] Merge the PR on sufficient approval. - [ ] Create a `vX.Y.Z` tag.