More pythonic way to find aind and mind for _summarize function #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More pythonic way to find aind and mind for _summarize function
bertsky
reviewed
Nov 30, 2021
Comment on lines
-435
to
+436
| aind = [i for i, aRng in enumerate(p.areaRngLbl) if aRng == areaRng] | ||
| mind = [i for i, mDet in enumerate(p.maxDets) if mDet == maxDets] | ||
| aind = p.areaRngLbl.index(areaRng) | ||
| mind = p.maxDets.index(maxDets) |
There was a problem hiding this comment.
That has different semantics though: your code only gives the first match and throws ValueError when nothing matches, whereas the original list allowed for multiple matches and may return an empty list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More pythonic way to find aind and mind for _summarize function