Skip to content

Commit 74994f3

Browse files
committed
fixed a bug where recording a second time the blue stop bar up top would not appear. cleaning up meta data for tagging and release
1 parent 4eb0c2b commit 74994f3

File tree

7 files changed

+14
-52
lines changed

7 files changed

+14
-52
lines changed

ios/RNReactNativeReplaykit.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// Created by Matt Thompson on 9/14/18.
2+
// MIT Licence.
13

24
#if __has_include("RCTBridgeModule.h")
35
#import "RCTBridgeModule.h"

ios/RNReactNativeReplaykit.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
// Created by Matt Thompson on 9/14/18.
2+
// MIT Licence.
13

24
#import "RNReactNativeReplaykit.h"
35
#import <React/RCTLog.h>
4-
//#import <AVAssetWriter>
56

67
#import "RNReactNativeReplaykit-Swift.h"
78

ios/ScreenRecord/FileUtil.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
1-
//
2-
// FileManager.swift
3-
// BugReporterTest
4-
//
51
// Created by Giridhar on 20/06/17.
6-
// Copyright © 2017 Giridhar. All rights reserved.
2+
// MIT Licence.
73
// Modified By: [
8-
// Matt Thompson 9/2018
4+
// Matt Thompson 9/14/18
95
//]
106

117

ios/ScreenRecord/ScreenRecordCoordinator.swift

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
1-
//
2-
// ScreenRecordCoordinator.swift
3-
// BugReporterTest
4-
//
51
// Created by Giridhar on 21/06/17.
6-
// Copyright © 2017 Giridhar. All rights reserved.
2+
// MIT Licence.
73
// Modified By: [
8-
// Matt Thompson 9/2018
4+
// Matt Thompson 9/14/18
95
//]
106

117
import Foundation
@@ -115,29 +111,3 @@ extension UIApplication {
115111
return base
116112
}
117113
}
118-
119-
120-
//extension FileManager {
121-
// func replaceWithCopyOfFile(at:URL, with:URL) {
122-
// do {
123-
// let url = try self.url(for: .itemReplacementDirectory, in: .userDomainMask, appropriateFor: with.deletingPathExtension(), create: true)
124-
// try self.copyItem(at: with, to: url.appendingPathComponent(with.lastPathComponent))
125-
//
126-
// let alert = NSAlert()
127-
// alert.messageText = "Replace \"\(at.lastPathComponent)\" in \"\(at.pathComponents[at.pathComponents.count - 2])\" with new file?"
128-
// alert.addButton(withTitle: "OK")
129-
// alert.addButton(withTitle: "Cancel")
130-
//
131-
// if alert.runModal() == NSAlertFirstButtonReturn {
132-
// _ = try FileManager.default.replaceItemAt(at, withItemAt: url.appendingPathComponent(with.lastPathComponent))
133-
// }
134-
//
135-
// // removes whole temporary directory as a clean up
136-
// try self.removeItem(at: url)
137-
// }
138-
// catch {
139-
// // error
140-
// print("unknown error")
141-
// }
142-
// }
143-
//}

ios/ScreenRecord/ScreenRecorder.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
1-
//
2-
// ScreenRecorder.swift
3-
// BugReporterTest
4-
//
51
// Created by Giridhar on 09/06/17.
6-
// Copyright © 2017 Giridhar. All rights reserved.
2+
// MIT Licence.
73
// Modified By: [
8-
// Matt Thompson 9/2018
4+
// Matt Thompson 9/14/18
95
//]
106

117
import Foundation

ios/ScreenRecord/WindowUtil.swift

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
1-
//
2-
// WindowUtil.swift
3-
// BugReporterTest
4-
//
51
// Created by Giridhar on 21/06/17.
6-
// Copyright © 2017 Giridhar. All rights reserved.
2+
// MIT Licence.
73
// Modified By: [
8-
// Matt Thompson 9/2018
4+
// Matt Thompson 9/14/18
95
//]
106

117
import Foundation
@@ -78,6 +74,7 @@ class WindowUtil: Overlayable
7874
func show()
7975
{
8076
DispatchQueue.main.async {
77+
self.stopButton.isHidden = false
8178
self.stopButton.transform = CGAffineTransform(translationX: 0, y: -30)
8279
self.stopButton.backgroundColor = self.stopButtonColor
8380
self.overlayWindow.makeKeyAndVisible()

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-replaykit",
3-
"version": "1.0.5",
3+
"version": "1.0.6",
44
"description": "A React Native module to access ReplayKit Screen Recording Framework on iOS",
55
"main": "index.js",
66
"license" : "MIT",

0 commit comments

Comments
 (0)