acquire_lock and release_lock should have been private

timvdalen · web-flow · commit dc7b05fe27da · 2018-03-14T15:35:28.000+01:00
diff --git a/src/Semaphore.php b/src/Semaphore.php
@@ -187,7 +187,7 @@ private function acquire_fair_with_lock() {
 	}
 
 	// From section 6.2 of the book
-	public function acquire_lock($acquire_timeout = 10) {
+	private function acquire_lock($acquire_timeout = 10) {
 		$identifier = (string)Uuid::uuid4();
 
 		$end = time() + $acquire_timeout;
@@ -200,7 +200,7 @@ public function acquire_lock($acquire_timeout = 10) {
 		}
 		return false;
 	}
-	public function release_lock($id) {
+	private function release_lock($id) {
 		$lockname = 'lock:' . $this->name;
 
 		$res = $this->client->transaction(['watch' => $lockname, 'cas' => true, 'retry' => 1000], function (MultiExec $t) use ($id, $lockname) {

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ private function acquire_fair_with_lock() {`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`// From section 6.2 of the book`
`190`		`- public function acquire_lock($acquire_timeout = 10) {`
	`190`	`+ private function acquire_lock($acquire_timeout = 10) {`
`191`	`191`	`$identifier = (string)Uuid::uuid4();`
`192`	`192`
`193`	`193`	`$end = time() + $acquire_timeout;`
`@@ -200,7 +200,7 @@ public function acquire_lock($acquire_timeout = 10) {`
`200`	`200`	`}`
`201`	`201`	`return false;`
`202`	`202`	`}`
`203`		`- public function release_lock($id) {`
	`203`	`+ private function release_lock($id) {`
`204`	`204`	`$lockname = 'lock:' . $this->name;`
`205`	`205`
`206`	`206`	`$res = $this->client->transaction(['watch' => $lockname, 'cas' => true, 'retry' => 1000], function (MultiExec $t) use ($id, $lockname) {`