refactor: wip

Author: BioPhoton

packages/utils/eslint.config.js

@@ -13,7 +13,11 @@ export default tseslint.config(
     },
   },
   {
-    files: ['packages/utils/src/lib/**/wal*.ts'],
+    files: [
+      'packages/utils/src/lib/**/wal*.ts',
+      'packages/utils/src/lib/**/wal*.test.ts',
+      'packages/utils/src/lib/profiler/*.test.ts',
+    ],
     rules: {
       'n/no-sync': 'off',
     },

packages/utils/mocks/multiprocess-profiling/profiler-worker-child.mjs

@@ -5,12 +5,10 @@ import {
   performDummyWork,
 } from './utils.js';
 
-(async () => {
-  await createBufferedEvents();
+await createBufferedEvents();
 
-  const profiler = new NodejsProfiler(getProfilerConfig());
+const profiler = new NodejsProfiler(getProfilerConfig());
 
-  await performDummyWork(profiler);
+await performDummyWork(profiler);
 
-  profiler.close();
-})();
+profiler.close();

packages/utils/mocks/multiprocess-profiling/profiler-worker.mjs

@@ -8,12 +8,14 @@ const [numProcesses] = process.argv.slice(2);
 
 if (!numProcesses) {
   console.error('Usage: node profiler-worker.mjs <numProcesses>');
+  // eslint-disable-next-line unicorn/no-process-exit,n/no-process-exit
   process.exit(1);
 }
 
 const numProcs = Number.parseInt(numProcesses, 10);
-if (isNaN(numProcs) || numProcs < 1) {
+if (Number.isNaN(numProcs) || numProcs < 1) {
   console.error('numProcesses must be a positive integer');
+  // eslint-disable-next-line unicorn/no-process-exit,n/no-process-exit
   process.exit(1);
 }
 
@@ -52,6 +54,7 @@ try {
   });
 
   profiler.close();
+  // eslint-disable-next-line no-console
   console.log(JSON.stringify(profiler.stats, null, 2));
 } catch (error) {
   // Ensure profiler is closed and stats are output even on error
@@ -60,11 +63,14 @@ try {
   }
   // Output stats if profiler was initialized, otherwise exit with error
   if (profiler) {
+    // eslint-disable-next-line no-console
     console.log(JSON.stringify(profiler.stats, null, 2));
     // Exit successfully since we've output the stats that the test needs
+    // eslint-disable-next-line unicorn/no-process-exit,n/no-process-exit
     process.exit(0);
   } else {
     console.error('Failed to initialize profiler:', error);
+    // eslint-disable-next-line unicorn/no-process-exit,n/no-process-exit
     process.exit(1);
   }
 }

packages/utils/mocks/multiprocess-profiling/utils.ts

@@ -1,5 +1,7 @@
-import { NodejsProfiler } from '../../src/lib/profiler/profiler-node.js';
-import type { NodejsProfilerOptions } from '../../src/lib/profiler/profiler-node.js';
+import {
+  NodejsProfiler,
+  type NodejsProfilerOptions,
+} from '../../src/lib/profiler/profiler-node.js';
 import { entryToTraceEvents } from '../../src/lib/profiler/trace-file-utils.js';
 import type { TraceEvent } from '../../src/lib/profiler/trace-file.type.js';
 import { traceEventWalFormat } from '../../src/lib/profiler/wal-json-trace.js';
@@ -70,6 +72,7 @@ export async function performDummyWork(
   // Random number of intervals (1-3) - reduced from 2-5
   const numIntervals = Math.floor(Math.random() * 3) + 1;
 
+  // eslint-disable-next-line functional/no-loop-statements
   for (let interval = 0; interval < numIntervals; interval++) {
     // Random interval delay (25-100ms)
     const intervalDelay = Math.floor(Math.random() * 75) + 25;
@@ -78,6 +81,7 @@ export async function performDummyWork(
     // Random number of work packages per interval (1-3)
     const numWorkPackages = Math.floor(Math.random() * 3) + 1;
 
+    // eslint-disable-next-line functional/no-loop-statements
     for (let pkg = 0; pkg < numWorkPackages; pkg++) {
       // Random work size (100-2,500,000 elements)
       const workSize = Math.floor(Math.random() * 2_500_000);

packages/utils/mocks/omit-trace-json.ts

@@ -125,9 +125,11 @@ export async function loadAndOmitTraceJson(
       traceEvents: normalizedEvents,
     };
     if (container.displayTimeUnit) {
+      // eslint-disable-next-line functional/immutable-data
       result.displayTimeUnit = container.displayTimeUnit;
     }
     if (container.metadata) {
+      // eslint-disable-next-line functional/immutable-data
       result.metadata = normalizeMetadata(container.metadata);
     }
     // Validate that the result can be serialized to valid JSON
@@ -251,9 +253,11 @@ function normalizeAndFormatEventsArray(
   const uniqueLocalIds = new Set<string>();
   const timestamps: number[] = [];
 
+  // eslint-disable-next-line functional/no-loop-statements
   for (const event of decodedEvents) {
     if (event.pid != null) uniquePids.add(event.pid);
     if (event.tid != null) uniqueTids.add(event.tid);
+    // eslint-disable-next-line functional/immutable-data
     timestamps.push(event.ts);
     if (event.id2?.local && typeof event.id2.local === 'string') {
       uniqueLocalIds.add(event.id2.local);
@@ -294,6 +298,7 @@ function normalizeAndFormatEventsArray(
 
     // Handle args normalization
     if (event.args?.data && typeof event.args.data === 'object') {
+      // eslint-disable-next-line functional/immutable-data
       normalized.args = {
         ...event.args,
         data: {
@@ -316,6 +321,7 @@ function normalizeAndFormatEventsArray(
       };
     } else if (event.args) {
       // Preserve args if it exists and has other properties
+      // eslint-disable-next-line functional/immutable-data
       normalized.args = event.args;
     }
     // If args is undefined or doesn't exist, don't include it
@@ -405,6 +411,7 @@ export async function loadNormalizedTraceJsonl(
  * @param container - Trace event container to validate
  */
 export function expectTraceDecodable(container: TraceEventContainer): void {
+  // eslint-disable-next-line functional/no-loop-statements
   for (const event of container.traceEvents) {
     if (event.cat === 'blink.user_timing') {
       expect(() => decodeEvent(event)).not.toThrow();

packages/utils/src/lib/profiler/profiler-node.int.test.ts

@@ -67,6 +67,7 @@ describe('NodeJS Profiler Integration', () => {
       debug: options.debug ?? false,
       measureName: options.measureName,
     });
+    // eslint-disable-next-line functional/immutable-data
     activeProfilers.push(profiler);
     return profiler;
   }
@@ -190,11 +191,13 @@ describe('NodeJS Profiler Integration', () => {
   });
 
   afterEach(() => {
+    // eslint-disable-next-line functional/no-loop-statements
     for (const profiler of activeProfilers) {
       if (profiler.stats.profilerState !== 'closed') {
         profiler.close();
       }
     }
+    // eslint-disable-next-line functional/immutable-data
     activeProfilers.length = 0;
 
     vi.stubEnv(PROFILER_ENABLED_ENV_VAR, undefined!);
@@ -420,8 +423,9 @@ describe('NodeJS Profiler Integration', () => {
     const processDuration = performance.now() - processStartTime;
 
     if (!stdout.trim()) {
+      const stderrMessage = stderr ? ` stderr: ${stderr}` : '';
       throw new Error(
-        `Worker process produced no stdout output.${stderr ? ` stderr: ${stderr}` : ''}`,
+        `Worker process produced no stdout output.${stderrMessage}`,
       );
     }
 
@@ -465,6 +469,7 @@ describe('NodeJS Profiler Integration', () => {
     const totalDuration = performance.now() - startTime;
 
     // Log timing information for debugging
+    // eslint-disable-next-line no-console
     console.log(
       `[Timing] Process execution: ${processDuration.toFixed(2)}ms, Validation: ${validationDuration.toFixed(2)}ms, Total: ${totalDuration.toFixed(2)}ms`,
     );

packages/utils/src/lib/profiler/profiler-node.unit.test.ts

@@ -378,7 +378,7 @@ describe('NodejsProfiler', () => {
       expect(shardPath).toContainPath('tmp/profiles/custom-filename');
       expect(shardPath).toMatch(/trace\.\d{8}-\d{6}-\d{3}(?:\.\d+){3}\.jsonl$/);
       // finalFilePath uses measureName as the identifier
-      expect(profiler.stats.finalFilePath).toBe(
+      expect(profiler.stats.finalFilePath).toMatchPath(
         `${PROFILER_PERSIST_OUT_DIR}/custom-filename/trace.custom-filename.json`,
       );
     });
@@ -441,7 +441,9 @@ describe('NodejsProfiler', () => {
         isCoordinator: true, // When no coordinator env var is set, this profiler becomes coordinator
         isFinalized: false,
         isCleaned: false,
-        finalFilePath: `${PROFILER_PERSIST_OUT_DIR}/stats-getter/trace.stats-getter.json`,
+        finalFilePath: expect.pathToMatch(
+          `${PROFILER_PERSIST_OUT_DIR}/stats-getter/trace.stats-getter.json`,
+        ),
         shardFileCount: 0,
         shardFiles: [],
         shardOpen: false,

packages/utils/src/lib/profiler/wal-json-trace.unit.test.ts

@@ -207,6 +207,7 @@ describe('traceEventCodec', () => {
 
     it('should handle multiple round-trips correctly', () => {
       let current = instantEvent;
+      // eslint-disable-next-line functional/no-loop-statements
       for (let i = 0; i < 3; i++) {
         const encoded = traceEventCodec.encode(current);
         const decoded = traceEventCodec.decode(encoded);

packages/utils/src/lib/wal-sharded.int.test.ts

@@ -82,6 +82,7 @@ describe('ShardedWal Integration', () => {
       groupId: 'merge-shards',
     });
 
+    // eslint-disable-next-line functional/no-loop-statements
     for (let i = 1; i <= 5; i++) {
       const shard = shardedWal.shard();
       shard.open();

packages/utils/src/lib/wal-sharded.unit.test.ts

@@ -26,7 +26,7 @@ describe('ShardedWal', () => {
     vol.reset();
     vol.fromJSON({}, MEMFS_VOLUME);
     // Clear coordinator env var for fresh state
-    // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+    // eslint-disable-next-line functional/immutable-data, @typescript-eslint/no-dynamic-delete
     delete process.env[PROFILER_SHARDER_ID_ENV_VAR];
   });
 
@@ -228,7 +228,7 @@ describe('ShardedWal', () => {
       });
 
       // Ensure no coordinator is set
-      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+      // eslint-disable-next-line functional/immutable-data, @typescript-eslint/no-dynamic-delete
       delete process.env[PROFILER_SHARDER_ID_ENV_VAR];
 
       const sw = getShardedWal({
@@ -249,7 +249,7 @@ describe('ShardedWal', () => {
       });
 
       // Ensure no coordinator is set
-      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+      // eslint-disable-next-line functional/immutable-data, @typescript-eslint/no-dynamic-delete
       delete process.env[PROFILER_SHARDER_ID_ENV_VAR];
 
       const sw = getShardedWal({
@@ -443,7 +443,7 @@ describe('ShardedWal', () => {
       });
 
       // Not coordinator - cleanupIfCoordinator should be no-op
-      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+      // eslint-disable-next-line functional/immutable-data, @typescript-eslint/no-dynamic-delete
       delete process.env[PROFILER_SHARDER_ID_ENV_VAR];
       sw.cleanupIfCoordinator();
       expect(vol.toJSON()).not.toStrictEqual({});