Skip to content

Commit 3085992

Browse files
authored
Merge pull request #78 from codeGROOVE-dev/reliable
use :large_green_circle: for outgoing
2 parents 004dedf + e6f769a commit 3085992

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

pkg/home/ui.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,9 @@ func BuildPRSections(incoming, outgoing []PR) []slack.Block {
140140
var indicator string
141141
switch {
142142
case prs[i].NeedsReview:
143-
indicator = ":red_circle:"
143+
indicator = ":large_red_circle:"
144144
case prs[i].IsBlocked:
145-
indicator = ":red_circle:"
145+
indicator = ":large_red_circle:"
146146
case prs[i].ActionKind != "":
147147
indicator = ":speech_balloon:"
148148
default:
@@ -207,9 +207,9 @@ func BuildPRSections(incoming, outgoing []PR) []slack.Block {
207207
var indicator string
208208
switch {
209209
case prs[i].NeedsReview:
210-
indicator = ":green_circle:"
210+
indicator = ":large_green_circle:"
211211
case prs[i].IsBlocked:
212-
indicator = ":green_circle:"
212+
indicator = ":large_green_circle:"
213213
case prs[i].ActionKind != "":
214214
indicator = ":speech_balloon:"
215215
default:

pkg/home/ui_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,13 @@ func TestBuildBlocks(t *testing.T) {
143143
foundBlockedPR := false
144144
for _, block := range blocks {
145145
if sb, ok := block.(*slack.SectionBlock); ok {
146-
if sb.Text != nil && strings.Contains(sb.Text.Text, ":red_circle:") {
146+
if sb.Text != nil && strings.Contains(sb.Text.Text, ":large_red_circle:") {
147147
foundBlockedPR = true
148148
}
149149
}
150150
}
151151
if !foundBlockedPR {
152-
t.Error("expected PR with :red_circle: indicating blocked incoming PR")
152+
t.Error("expected PR with :large_red_circle: indicating blocked incoming PR")
153153
}
154154
},
155155
},
@@ -195,13 +195,13 @@ func TestBuildBlocks(t *testing.T) {
195195
foundBlocked := false
196196
for _, block := range blocks {
197197
if sb, ok := block.(*slack.SectionBlock); ok {
198-
if sb.Text != nil && strings.Contains(sb.Text.Text, ":green_circle:") {
198+
if sb.Text != nil && strings.Contains(sb.Text.Text, ":large_green_circle:") {
199199
foundBlocked = true
200200
}
201201
}
202202
}
203203
if !foundBlocked {
204-
t.Error("expected PR with :green_circle: for blocked outgoing PR")
204+
t.Error("expected PR with :large_green_circle: for blocked outgoing PR")
205205
}
206206
},
207207
},
@@ -410,10 +410,10 @@ func TestBuildPRSections_SortOrder(t *testing.T) {
410410
}
411411

412412
// Verify color indicators
413-
if !strings.Contains(incomingText, ":red_circle:") {
414-
t.Error("incoming blocked PRs should use :red_circle:")
413+
if !strings.Contains(incomingText, ":large_red_circle:") {
414+
t.Error("incoming blocked PRs should use :large_red_circle:")
415415
}
416-
if !strings.Contains(outgoingText, ":green_circle:") {
417-
t.Error("outgoing blocked PRs should use :green_circle:")
416+
if !strings.Contains(outgoingText, ":large_green_circle:") {
417+
t.Error("outgoing blocked PRs should use :large_green_circle:")
418418
}
419419
}

0 commit comments

Comments
 (0)