Added not-found error message for hostname search (#47)

* Added not-found error message for address search
* Add test for PHPyPAMEntityNotFoundException
  Refactor exception.py to make `_NOT_FOUND_MESSAGES` available outside
  exception definition.
  Add test method for testing not found exceptions. Iterate over a list of
  dicts with test data.
  Add fixture for the new test case for not found exception.
* add changelog entry

Co-authored-by: cmeissner

Author: mattiasa

CHANGELOG.md

@@ -9,6 +9,7 @@
 ### Changes
 
 ### Fixes
+* fix #48 - raise PHPyPAMEntityNotFoundException if searching for non existing host
 
 ### Breaks
 

phpypam/core/exceptions.py

@@ -7,6 +7,17 @@ class PHPyPAMException(Exception):
     This exception is raised if anythings in :class:`phpypam.api` doesn't work out.
     """
 
+    _NOT_FOUND_MESSAGES = {
+        'No subnets found',
+        'Address not found',
+        'Vlan not found',
+        'No vrfs configured',
+        'No devices configured',
+        'No results (filter applied)',
+        'No objects found',
+        'Hostname not found'
+    }
+
     def __init__(self, *args, code=None, message=None):
         """Generate PHPyPAMException.
 
@@ -24,17 +35,7 @@ def __init__(self, *args, code=None, message=None):
         self._code = code
         self._message = message
 
-        _NOT_FOUND_MESSAGES = {
-            'No subnets found',
-            'Address not found',
-            'Vlan not found',
-            'No vrfs configured',
-            'No devices configured',
-            'No results (filter applied)',
-            'No objects found',
-        }
-
-        if (self._code == 200 and self._message in _NOT_FOUND_MESSAGES) or self._code == 404:
+        if (self._code == 200 and self._message in self._NOT_FOUND_MESSAGES) or self._code == 404:
             raise PHPyPAMEntityNotFoundException(self._message)
         elif self._code == 500:
             if self._message == 'Invalid username or password':