Skip to content

Conversation

@StanBarrows
Copy link
Contributor

…Year

Copilot AI review requested due to automatic review settings November 10, 2025 09:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for granular address fields across multiple DTOs to replace the deprecated single address field. It also adds new fields for calendar year reporting and bank account owner information.

  • Introduces structured address fields (street_name, house_number, address_addition) to replace the deprecated address field in Contact and AdditionalAddress DTOs
  • Adds name_addition field to AdditionalAddress DTOs
  • Extends BankAccountDTO with owner_house_number and owner_country_code fields
  • Adds is_annual_reporting boolean field to CalendarYearDTO

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Dto/Contacts/CreateEditContactDTO.php Adds structured address fields (street_name, house_number, address_addition) while marking the original address field as deprecated
src/Dto/Contacts/ContactDTO.php Adds structured address fields (street_name, house_number, address_addition) while marking the original address field as deprecated
src/Dto/CalendarYears/CalendarYearDTO.php Adds is_annual_reporting boolean field to track annual reporting status
src/Dto/BankAccounts/BankAccountDTO.php Extends owner information with house_number and country_code fields
src/Dto/AdditionalAddresses/CreateEditAdditionalAddressDTO.php Adds name_addition field and structured address fields while marking address as deprecated
src/Dto/AdditionalAddresses/AdditionalAddressDTO.php Adds name_addition field and structured address fields while marking address as deprecated
Comments suppressed due to low confidence (1)

src/Dto/AdditionalAddresses/AdditionalAddressDTO.php:56

  • The parameter order in fromArray doesn't match the constructor parameter order. The constructor has subject and description after name_addition (lines 16-17), but in fromArray they are passed after address_addition (lines 55-56). This inconsistency could lead to confusion and maintenance issues. Consider reordering the parameters in fromArray to match the constructor order.
        return new self(
            id: Arr::get($data, 'id'),
            name: Arr::get($data, 'name'),
            name_addition: Arr::get($data, 'name_addition'),
            address: Arr::get($data, 'address'),
            street_name: Arr::get($data, 'street_name'),
            house_number: Arr::get($data, 'house_number'),
            address_addition: Arr::get($data, 'address_addition'),
            postcode: Arr::get($data, 'postcode'),
            city: Arr::get($data, 'city'),
            country_id: Arr::get($data, 'country_id'),
            subject: Arr::get($data, 'subject'),
            description: Arr::get($data, 'description'),

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StanBarrows StanBarrows changed the title Feature Contacts v2 Feature Update API Nov 10, 2025
@StanBarrows StanBarrows deleted the feature-contacts-v2 branch November 10, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants