WIP

RhysLees · RhysLees · commit 0d7fd6a00e62 · 2025-02-27T11:07:00.000Z
diff --git a/src/Classes/RequestClass.php b/src/Classes/RequestClass.php
@@ -30,7 +30,7 @@ public function __construct()
         $this->ignoreReferenceErrorIngore = config('zammad.object_reference_error_ignore');
         $this->objectHasReferenceError = config('zammad.objet_reference_error');
 
-        $this->connector = new ZammadConnector();
+        $this->connector = new ZammadConnector;
     }
 
     private function performRequest(Request $request): Response
diff --git a/src/DTO/Attachment.php b/src/DTO/Attachment.php
@@ -28,8 +28,7 @@ public function __construct(
         public int $size,
         public string $name,
         public string $type,
-    ) {
-    }
+    ) {}
 
     public function url(): string
     {
diff --git a/src/DTO/Comment.php b/src/DTO/Comment.php
@@ -89,8 +89,7 @@ public function __construct(
         public Collection $attachments,
         public Carbon $updated_at,
         public Carbon $created_at,
-    ) {
-    }
+    ) {}
 
     public static function fake(
         ?int $id = null,
diff --git a/src/DTO/ObjectAttribute.php b/src/DTO/ObjectAttribute.php
@@ -31,8 +31,7 @@ public function __construct(
         public int $position,
         public array $data_option,
         public ?array $data_option_new,
-    ) {
-    }
+    ) {}
 
     public static function fake(
         ?int $id = null,
diff --git a/src/DTO/User.php b/src/DTO/User.php
@@ -31,8 +31,7 @@ public function __construct(
         public Carbon $updated_at,
         public Carbon $created_at,
         public ?array $expanded = null,
-    ) {
-    }
+    ) {}
 
     public static function fake(
         ?int $id = null,
diff --git a/src/Events/ZammadResponseLog.php b/src/Events/ZammadResponseLog.php
@@ -13,7 +13,5 @@ class ZammadResponseLog
     use InteractsWithSockets;
     use SerializesModels;
 
-    public function __construct(public Response $response)
-    {
-    }
+    public function __construct(public Response $response) {}
 }
diff --git a/src/Requests/AccessTokens/CreateAccessTokenRequest.php b/src/Requests/AccessTokens/CreateAccessTokenRequest.php
@@ -15,8 +15,7 @@ class CreateAccessTokenRequest extends Request implements HasBody
 
     public function __construct(
         protected array $payload
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/AccessTokens/DestroyAccessTokenRequest.php b/src/Requests/AccessTokens/DestroyAccessTokenRequest.php
@@ -12,8 +12,7 @@ class DestroyAccessTokenRequest extends Request
     public function __construct(
         public int $id,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Attachment/GetAttachmentRequest.php b/src/Requests/Attachment/GetAttachmentRequest.php
@@ -13,8 +13,7 @@ public function __construct(
         public int $ticketId,
         public int $commentId,
         public int $attachmentId,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Comments/CreateCommentRequest.php b/src/Requests/Comments/CreateCommentRequest.php
@@ -17,8 +17,7 @@ class CreateCommentRequest extends Request implements HasBody
 
     public function __construct(
         protected array $payload
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Comments/DestroyCommentRequest.php b/src/Requests/Comments/DestroyCommentRequest.php
@@ -11,8 +11,7 @@ class DestroyCommentRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Comments/GetCommentByTicketRequest.php b/src/Requests/Comments/GetCommentByTicketRequest.php
@@ -11,8 +11,7 @@ class GetCommentByTicketRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Comments/GetCommentRequest.php b/src/Requests/Comments/GetCommentRequest.php
@@ -13,8 +13,7 @@ class GetCommentRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/ObjectAttribute/CreateObjectAttributeRequest.php b/src/Requests/ObjectAttribute/CreateObjectAttributeRequest.php
@@ -17,8 +17,7 @@ class CreateObjectAttributeRequest extends Request implements HasBody
 
     public function __construct(
         protected array $payload
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/ObjectAttribute/DestroyObjectAttributeRequest.php b/src/Requests/ObjectAttribute/DestroyObjectAttributeRequest.php
@@ -11,8 +11,7 @@ class DestroyObjectAttributeRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/ObjectAttribute/GetObjectAttributeRequest.php b/src/Requests/ObjectAttribute/GetObjectAttributeRequest.php
@@ -13,8 +13,7 @@ class GetObjectAttributeRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/ObjectAttribute/UpdateObjectAttributeRequest.php b/src/Requests/ObjectAttribute/UpdateObjectAttributeRequest.php
@@ -18,8 +18,7 @@ class UpdateObjectAttributeRequest extends Request implements HasBody
     public function __construct(
         public int $id,
         public array $payload
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/AllTicketsRequest.php b/src/Requests/Tickets/AllTicketsRequest.php
@@ -12,8 +12,7 @@ class AllTicketsRequest extends Request
     public function __construct(
         public ?int $perPage = null,
         public ?int $page = null,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/CreateTicketRequest.php b/src/Requests/Tickets/CreateTicketRequest.php
@@ -18,8 +18,7 @@ class CreateTicketRequest extends Request implements HasBody
     public function __construct(
         protected array $payload,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/DestroyTicketRequest.php b/src/Requests/Tickets/DestroyTicketRequest.php
@@ -11,8 +11,7 @@ class DestroyTicketRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/GetTicketRequest.php b/src/Requests/Tickets/GetTicketRequest.php
@@ -14,8 +14,7 @@ class GetTicketRequest extends Request
     public function __construct(
         public int $id,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Tickets/SearchTicketRequest.php b/src/Requests/Tickets/SearchTicketRequest.php
@@ -14,8 +14,7 @@ public function __construct(
         public ?int $limit = null,
         public ?int $perPage = null,
         public ?int $page = null,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/AllUsersRequest.php b/src/Requests/Users/AllUsersRequest.php
@@ -12,8 +12,7 @@ class AllUsersRequest extends Request
     public function __construct(
         public ?int $perPage = null,
         public ?int $page = null,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/CreateUserRequest.php b/src/Requests/Users/CreateUserRequest.php
@@ -18,8 +18,7 @@ class CreateUserRequest extends Request implements HasBody
     public function __construct(
         protected array $payload,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/DestroyUserRequest.php b/src/Requests/Users/DestroyUserRequest.php
@@ -11,8 +11,7 @@ class DestroyUserRequest extends Request
 
     public function __construct(
         public int $id
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/GetUserRequest.php b/src/Requests/Users/GetUserRequest.php
@@ -14,8 +14,7 @@ class GetUserRequest extends Request
     public function __construct(
         public ?int $id = null,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/SearchUserRequest.php b/src/Requests/Users/SearchUserRequest.php
@@ -12,8 +12,7 @@ class SearchUserRequest extends Request
     public function __construct(
         public string $term,
         public ?int $limit = null,
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Requests/Users/UpdateUserRequest.php b/src/Requests/Users/UpdateUserRequest.php
@@ -19,8 +19,7 @@ public function __construct(
         public int $id,
         public array $payload,
         public bool $expand = false
-    ) {
-    }
+    ) {}
 
     public function resolveEndpoint(): string
     {
diff --git a/src/Zammad.php b/src/Zammad.php
@@ -13,31 +13,31 @@ class Zammad
 {
     public function user(): UserResource
     {
-        return new UserResource();
+        return new UserResource;
     }
 
     public function userAccessToken(): UserAccessToken
     {
-        return new UserAccessToken();
+        return new UserAccessToken;
     }
 
     public function ticket(): TicketResource
     {
-        return new TicketResource();
+        return new TicketResource;
     }
 
     public function comment(): CommentResource
     {
-        return new CommentResource();
+        return new CommentResource;
     }
 
     public function attachment(): AttachmentResource
     {
-        return new AttachmentResource();
+        return new AttachmentResource;
     }
 
     public function object(): ObjectAttributeResource
     {
-        return new ObjectAttributeResource();
+        return new ObjectAttributeResource;
     }
 }
diff --git a/tests/Feature/AttachmentResourceTest.php b/tests/Feature/AttachmentResourceTest.php
@@ -5,7 +5,7 @@
 use Illuminate\Support\Facades\Event;
 
 it('can download an attachment', function () {
-    $content = (new Zammad())->attachment()->download(
+    $content = (new Zammad)->attachment()->download(
         ticketId: 32,
         commentId: 111,
         attachmentId: 42,
diff --git a/tests/Feature/CommentResourceTest.php b/tests/Feature/CommentResourceTest.php
@@ -13,7 +13,7 @@
 it('does show by ticket', function () {
     $id = 32;
 
-    $comments = (new Zammad())->comment()->showByTicket($id);
+    $comments = (new Zammad)->comment()->showByTicket($id);
 
     $this->assertInstanceOf(Collection::class, $comments);
 
@@ -28,7 +28,7 @@
 it('does show comment', function () {
     $id = 66;
 
-    $comment = (new Zammad())->comment()->show($id);
+    $comment = (new Zammad)->comment()->show($id);
 
     $this->assertInstanceOf(Comment::class, $comment);
     $this->assertSame($id, $comment->id);
@@ -50,7 +50,7 @@
         ],
     ];
 
-    $comment = (new Zammad())->comment()->create($data);
+    $comment = (new Zammad)->comment()->create($data);
 
     $this->assertInstanceOf(Comment::class, $comment);
     $this->assertSame('::subject::', $comment->subject);
@@ -64,12 +64,12 @@
         $this->assertSame('text/plain', $attachment->type);
     });
     Event::assertDispatched(ZammadResponseLog::class, 1);
-    (new Zammad())->comment()->delete($comment->id);
+    (new Zammad)->comment()->delete($comment->id);
     Event::assertDispatched(ZammadResponseLog::class, 2);
 })->group('comments');
 
 it('does parse body from comment', function () {
-    $comment = (new Zammad())->comment()->show(342);
+    $comment = (new Zammad)->comment()->show(342);
 
     $this->assertStringContainsString(
         'Abgeschieden wohnen sie in Buchstabhausen an der Küste des Semantik, eines großen Sprachozeans.',
@@ -88,7 +88,7 @@
 it('has a from name helper', function () {
     $id = 66;
 
-    $comment = (new Zammad())->comment()->show($id);
+    $comment = (new Zammad)->comment()->show($id);
 
     $this->assertSame(
         Str::before(Str::between($comment->from, '"', '"'), '<'),
@@ -99,7 +99,7 @@
 it('has a from email helper', function () {
     $id = 66;
 
-    $comment = (new Zammad())->comment()->show($id);
+    $comment = (new Zammad)->comment()->show($id);
 
     $this->assertSame(
         Str::between($comment->from, '<', '>'),
diff --git a/tests/Feature/ObjectAttributeResourceTest.php b/tests/Feature/ObjectAttributeResourceTest.php
diff --git a/tests/Feature/TicketResourceTest.php b/tests/Feature/TicketResourceTest.php
diff --git a/tests/Feature/UserAccessTokenRequestTest.php b/tests/Feature/UserAccessTokenRequestTest.php
diff --git a/tests/Feature/UserResourceTest.php b/tests/Feature/UserResourceTest.php
diff --git a/tests/Feature/ZammadConnectorTest.php b/tests/Feature/ZammadConnectorTest.php

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function __construct()`
`30`	`30`	`$this->ignoreReferenceErrorIngore = config('zammad.object_reference_error_ignore');`
`31`	`31`	`$this->objectHasReferenceError = config('zammad.objet_reference_error');`
`32`	`32`
`33`		`- $this->connector = new ZammadConnector();`
	`33`	`+ $this->connector = new ZammadConnector;`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`private function performRequest(Request $request): Response`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,7 @@ public function __construct(`
`28`	`28`	`public int $size,`
`29`	`29`	`public string $name,`
`30`	`30`	`public string $type,`
`31`		`- ) {`
`32`		`- }`
	`31`	`+ ) {}`
`33`	`32`
`34`	`33`	`public function url(): string`
`35`	`34`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,5 @@ class ZammadResponseLog`
`13`	`13`	`use InteractsWithSockets;`
`14`	`14`	`use SerializesModels;`
`15`	`15`
`16`		`- public function __construct(public Response $response)`
`17`		`- {`
`18`		`- }`
	`16`	`+ public function __construct(public Response $response) {}`
`19`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,7 @@ class CreateAccessTokenRequest extends Request implements HasBody`
`15`	`15`
`16`	`16`	`public function __construct(`
`17`	`17`	`protected array $payload`
`18`		`- ) {`
`19`		`- }`
	`18`	`+ ) {}`
`20`	`19`
`21`	`20`	`public function resolveEndpoint(): string`
`22`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,7 @@ class DestroyAccessTokenRequest extends Request`
`12`	`12`	`public function __construct(`
`13`	`13`	`public int $id,`
`14`	`14`	`public bool $expand = false`
`15`		`- ) {`
`16`		`- }`
	`15`	`+ ) {}`
`17`	`16`
`18`	`17`	`public function resolveEndpoint(): string`
`19`	`18`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,7 @@ public function __construct(`
`13`	`13`	`public int $ticketId,`
`14`	`14`	`public int $commentId,`
`15`	`15`	`public int $attachmentId,`
`16`		`- ) {`
`17`		`- }`
	`16`	`+ ) {}`
`18`	`17`
`19`	`18`	`public function resolveEndpoint(): string`
`20`	`19`	`{`
Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,7 @@ class CreateCommentRequest extends Request implements HasBody`
`17`	`17`
`18`	`18`	`public function __construct(`
`19`	`19`	`protected array $payload`
`20`		`- ) {`
`21`		`- }`
	`20`	`+ ) {}`
`22`	`21`
`23`	`22`	`public function resolveEndpoint(): string`
`24`	`23`	`{`