1.0.1 handle not so well formed testsuites

Author: Bernhard Grünewaldt

pom.xml

@@ -4,7 +4,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>io.codeclou</groupId>
   <artifactId>java-junit-xml-merger</artifactId>
-  <version>1.0.0</version>
+  <version>1.0.1</version>
   <organization>
     <name>codeclou.io</name>
     <url>http://codeclou.io/</url>

src/main/java/io/codeclou/java/junit/xml/merger/JunitXmlParser.java

@@ -27,6 +27,7 @@
 import io.codeclou.java.junit.xml.merger.model.TestSuites;
 import org.apache.commons.cli.*;
 import org.w3c.dom.Document;
+import org.w3c.dom.NamedNodeMap;
 import org.w3c.dom.Node;
 import org.xml.sax.SAXException;
 
@@ -59,12 +60,13 @@ protected TestSuite parseTestSuite(File filename) throws ParserConfigurationExce
 
     public TestSuite transform(Node testSuite) {
         TestSuite t = new TestSuite();
-        t.setTests(Long.valueOf(testSuite.getAttributes().getNamedItem("tests").getNodeValue()));
-        t.setErrors(Long.valueOf(testSuite.getAttributes().getNamedItem("errors").getNodeValue()));
-        t.setFailures(Long.valueOf(testSuite.getAttributes().getNamedItem("failures").getNodeValue()));
-        t.setSkipped(Long.valueOf(testSuite.getAttributes().getNamedItem("skipped").getNodeValue()));
+        NamedNodeMap attrs = testSuite.getAttributes();
+        t.setTests(attrs.getNamedItem("tests") != null ? Long.valueOf(attrs.getNamedItem("tests").getNodeValue()) : 0L);
+        t.setErrors(attrs.getNamedItem("errors") != null ? Long.valueOf(testSuite.getAttributes().getNamedItem("errors").getNodeValue()) : 0L);
+        t.setFailures(attrs.getNamedItem("failures") != null ? Long.valueOf(testSuite.getAttributes().getNamedItem("failures").getNodeValue()) : 0L);
+        t.setSkipped(attrs.getNamedItem("skipped") != null ? Long.valueOf(testSuite.getAttributes().getNamedItem("skipped").getNodeValue()) : 0L);
         t.setName(testSuite.getAttributes().getNamedItem("name").getNodeValue());
-        t.setTime(Double.valueOf(testSuite.getAttributes().getNamedItem("time").getNodeValue()));
+        t.setTime(attrs.getNamedItem("time") != null ? Double.valueOf(testSuite.getAttributes().getNamedItem("time").getNodeValue()) : 0.0);
         t.setXml(testSuite);
         return t;
     }

src/test/java/io/codeclou/java/junit/xml/merger/JunitXmlParserTest.java

@@ -52,6 +52,19 @@ public void testParse() throws Exception {
         assertNotNull(t.getXml());
     }
 
+    @Test
+    public void testParseNotSoWellFormed() throws Exception {
+        JunitXmlParser parser = new JunitXmlParser();
+        TestSuite t = parser.parseTestSuite(getTestFile("my-not-so-well-formed-component-test.xml"));
+        assertEquals(Long.valueOf(0L), t.getErrors());
+        assertEquals(Long.valueOf(0L), t.getFailures());
+        assertEquals(Long.valueOf(0L), t.getSkipped());
+        assertEquals(Long.valueOf(0L), t.getTests());
+        assertTrue(t.getTime() >= 0.0);
+        assertEquals("i.am.empty.but.sometimes.that.happens", t.getName());
+        assertNotNull(t.getXml());
+    }
+
     @Test
     public void testRunInvalidInput1() throws Exception {
         String[] args = {};

src/test/resources/my-not-so-well-formed-component-test.xml

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<testsuite name="i.am.empty.but.sometimes.that.happens">
+</testsuite>