change skip-calidation flag to behind-firewall (#281)

Author: Oleg Sucharevich

lib/interface/cli/commands/context/create/git/base.cmd.js

@@ -23,8 +23,8 @@ const command = new Command({
                 choices: ['AccountAdmins', 'AllUsersInAccount'],
                 default: 'AccountAdmins',
             })
-            .option('skip-validation', {
-                describe: 'Set to true to skip validation',
+            .option('behind-firewall', {
+                describe: 'Set to true to mark this context with behind firewall flag',
                 type: 'boolean',
                 default: false,
             });

lib/interface/cli/commands/context/create/git/types/bitbucket.cmd.js

@@ -44,6 +44,7 @@ const command = new Command({
             spec: {
                 type: 'git.bitbucket',
                 data: {
+                    behindFirewall: argv.behindFirewall,
                     sharingPolicy: argv.sharingPolicy,
                     auth: {
                         type: 'basic',
@@ -58,11 +59,7 @@ const command = new Command({
         if (!data.metadata.name || !data.spec.type) {
             throw new CFError('Name and type must be provided');
         }
-        const opt = {};
-        if (argv.skipValidation) {
-            opt.skipValidation = true;
-        }
-        await context.createContext(data, opt);
+        await context.createContext(data);
         console.log(`Context: ${data.metadata.name} created`);
     },
 });

lib/interface/cli/commands/context/create/git/types/github.cmd.js

@@ -34,7 +34,7 @@ const command = new Command({
                 default: DEFAULT_API_HOST,
                 required: true,
             })
-            .option('api', {
+            .option('api-path-prefix', {
                 describe: 'Prefix of the api on the given host',
                 alias: 'a',
                 default: DEFAULT_API_PREFIX,
@@ -52,6 +52,7 @@ const command = new Command({
             spec: {
                 type: 'git.github',
                 data: {
+                    behindFirewall: argv.behindFirewall,
                     sharingPolicy: argv.sharingPolicy,
                     auth: {
                         type: 'basic',
@@ -72,11 +73,7 @@ const command = new Command({
         if (!data.metadata.name || !data.spec.type) {
             throw new CFError('Name and type must be provided');
         }
-        const opt = {};
-        if (argv.skipValidation) {
-            opt.skipValidation = true;
-        }
-        await context.createContext(data, opt);
+        await context.createContext(data);
         console.log(`Context: ${data.metadata.name} created`);
     },
 });

lib/interface/cli/commands/context/create/git/types/gitlab.cmd.js

@@ -46,6 +46,7 @@ const command = new Command({
             spec: {
                 type: 'git.gitlab',
                 data: {
+                    behindFirewall: argv.behindFirewall,
                     sharingPolicy: argv.sharingPolicy,
                     auth: {
                         type: 'basic',
@@ -63,11 +64,7 @@ const command = new Command({
         if (!data.metadata.name || !data.spec.type) {
             throw new CFError('Name and type must be provided');
         }
-        const opt = {};
-        if (argv.skipValidation) {
-            opt.skipValidation = true;
-        }
-        await context.createContext(data, opt);
+        await context.createContext(data);
         console.log(`Context: ${data.metadata.name} created`);
     },
 });

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.12.0",
+  "version": "0.13.0",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,