refactor: fix static analysis problems

Author: patel-vansh

system/Config/BaseConfig.php

@@ -139,7 +139,7 @@ public function __construct()
                 } elseif ($property === 'previousKeys') {
                     // previousKeys must be an array
                     if (is_string($this->{$property})) {
-                        $this->{$property} = array_map(fn ($item) => $this->parseEncryptionKey($item), explode(',', $this->{$property}));
+                        $this->{$property} = array_map(fn ($item): string => $this->parseEncryptionKey($item), explode(',', $this->{$property}));
                     }
                 }
             }

system/Encryption/Handlers/OpenSSLHandler.php

@@ -91,7 +91,7 @@ class OpenSSLHandler extends BaseHandler
     /**
      * {@inheritDoc}
      */
-    public function encrypt(#[SensitiveParameter] $data, #[SensitiveParameter] $params = null)
+    public function encrypt($data, $params = null)
     {
         // Allow key override
         if ($params !== null) {
@@ -127,7 +127,7 @@ public function encrypt(#[SensitiveParameter] $data, #[SensitiveParameter] $para
     /**
      * {@inheritDoc}
      */
-    public function decrypt($data, #[SensitiveParameter] $params = null)
+    public function decrypt($data, $params = null)
     {
         // Allow key override
         if ($params !== null) {
@@ -145,7 +145,7 @@ public function decrypt($data, #[SensitiveParameter] $params = null)
             $exception = $e;
         }
 
-        if ($result === false && $this->previousKeysFallbackEnabled && ! empty($this->previousKeys)) {
+        if ($result === false && $this->previousKeysFallbackEnabled && $this->previousKeys !== []) {
             foreach ($this->previousKeys as $previousKey) {
                 try {
                     $result = $this->decryptWithKey($data, $previousKey);
@@ -175,7 +175,7 @@ public function decrypt($data, #[SensitiveParameter] $params = null)
      *
      * @throws EncryptionException
      */
-    protected function decryptWithKey($data, #[SensitiveParameter] $key)
+    protected function decryptWithKey($data, $key)
     {
         // derive a secret key
         $authKey = \hash_hkdf($this->digest, $key, 0, $this->authKeyInfo);

system/Encryption/Handlers/SodiumHandler.php

@@ -52,7 +52,7 @@ class SodiumHandler extends BaseHandler
     /**
      * {@inheritDoc}
      */
-    public function encrypt(#[SensitiveParameter] $data, #[SensitiveParameter] $params = null)
+    public function encrypt($data, $params = null)
     {
         $this->parseParams($params);
 
@@ -83,7 +83,7 @@ public function encrypt(#[SensitiveParameter] $data, #[SensitiveParameter] $para
     /**
      * {@inheritDoc}
      */
-    public function decrypt($data, #[SensitiveParameter] $params = null)
+    public function decrypt($data, $params = null)
     {
         $this->parseParams($params);
 
@@ -100,7 +100,7 @@ public function decrypt($data, #[SensitiveParameter] $params = null)
             sodium_memzero($this->key);
         }
 
-        if ($result === false && $this->previousKeysFallbackEnabled && ! empty($this->previousKeys)) {
+        if ($result === false && $this->previousKeysFallbackEnabled && $this->previousKeys !== []) {
             foreach ($this->previousKeys as $previousKey) {
                 try {
                     $result = $this->decryptWithKey($data, $previousKey);
@@ -130,7 +130,7 @@ public function decrypt($data, #[SensitiveParameter] $params = null)
      *
      * @throws EncryptionException
      */
-    protected function decryptWithKey($data, #[SensitiveParameter] $key)
+    protected function decryptWithKey($data, $key)
     {
         if (mb_strlen($data, '8bit') < (SODIUM_CRYPTO_SECRETBOX_NONCEBYTES + SODIUM_CRYPTO_SECRETBOX_MACBYTES)) {
             // message was truncated