test: turn MySQLi $strictOn to true by default

Author: paulbalandan

app/Config/Database.php

@@ -177,7 +177,7 @@ class Database extends Config
         'swapPre'     => '',
         'encrypt'     => false,
         'compress'    => false,
-        'strictOn'    => false,
+        'strictOn'    => true,
         'failover'    => [],
         'port'        => 3306,
         'foreignKeys' => true,

tests/_support/Config/Registrar.php

@@ -41,7 +41,7 @@ class Registrar
             'swapPre'  => '',
             'encrypt'  => false,
             'compress' => false,
-            'strictOn' => false,
+            'strictOn' => true,
             'failover' => [],
             'port'     => 3306,
         ],
@@ -60,7 +60,7 @@ class Registrar
             'swapPre'  => '',
             'encrypt'  => false,
             'compress' => false,
-            'strictOn' => false,
+            'strictOn' => true, // @todo 4.8.0 to remove
             'failover' => [],
             'port'     => 5432,
         ],
@@ -79,7 +79,7 @@ class Registrar
             'swapPre'     => '',
             'encrypt'     => false,
             'compress'    => false,
-            'strictOn'    => false,
+            'strictOn'    => true, // @todo 4.8.0 to remove
             'failover'    => [],
             'port'        => 3306,
             'foreignKeys' => true,
@@ -100,7 +100,7 @@ class Registrar
             'swapPre'  => '',
             'encrypt'  => false,
             'compress' => false,
-            'strictOn' => false,
+            'strictOn' => true, // @todo 4.8.0 to remove
             'failover' => [],
             'port'     => 1433,
         ],
@@ -119,7 +119,7 @@ class Registrar
             'swapPre'  => '',
             'encrypt'  => false,
             'compress' => false,
-            'strictOn' => false,
+            'strictOn' => true, // @todo 4.8.0 to remove
             'failover' => [],
         ],
     ];

tests/system/Database/Live/InsertTest.php

@@ -30,13 +30,8 @@ final class InsertTest extends CIUnitTestCase
 {
     use DatabaseTestTrait;
 
-    /**
-     * @var Forge
-     */
-    public $forge;
-
-    protected $refresh = true;
-    protected $seed    = CITestSeeder::class;
+    protected $seed = CITestSeeder::class;
+    private Forge $forge;
 
     public function testInsert(): void
     {
@@ -93,26 +88,10 @@ public function testInsertBatchFailed(): void
     {
         $this->expectException(DatabaseException::class);
 
-        $data = [
-            [
-                'name' => 'Grocery Sales',
-            ],
-            [
-                'name' => null,
-            ],
-        ];
-
-        $db = $this->db;
-
-        if ($this->db->DBDriver === 'MySQLi') {
-            // strict mode is required for MySQLi to throw an exception here
-            $config                    = config('Database');
-            $config->tests['strictOn'] = true;
-
-            $db = Database::connect($config->tests);
-        }
-
-        $db->table('job')->insertBatch($data);
+        $this->db->table('job')->insertBatch([
+            ['name' => 'Grocery Sales'],
+            ['name' => null],
+        ]);
     }
 
     public function testReplaceWithNoMatchingData(): void

tests/system/Database/Live/TransactionTest.php

@@ -245,33 +245,16 @@ public function testTransStrictFalseAndDBDebugFalse(): void
      */
     public function testTransInsertBatchFailed(): void
     {
-        $data = [
-            [
-                'name' => 'Grocery Sales',
-            ],
-            [
-                'name' => null,
-            ],
-        ];
-
-        $db = $this->db;
-
-        if ($this->db->DBDriver === 'MySQLi') {
-            // strict mode is required for MySQLi to throw an exception here
-            $config                    = config('Database');
-            $config->tests['strictOn'] = true;
-
-            $db = Database::connect($config->tests);
-        }
+        $this->db->transStrict(false)->transBegin();
+        $this->db->table('job')->insertBatch([
+            ['name' => 'Grocery Sales'],
+            ['name' => null],
+        ]);
 
-        $db->transStrict(false)->transBegin();
-        $db->table('job')->insertBatch($data);
-
-        $this->assertFalse($db->transStatus());
-
-        $db->transComplete();
+        $this->assertFalse($this->db->transStatus());
 
-        $db->transStrict();
+        $this->db->transComplete();
+        $this->db->transStrict();
 
         $this->dontSeeInDatabase('job', ['name' => 'Grocery Sales']);
     }