Merge pull request #79 from wwwednesday/master

Eslint update + some fixes

Author: akella

generators/app/templates/eslintignore

@@ -0,0 +1 @@
+src/js/lib

generators/app/templates/eslintrc

@@ -11,6 +11,7 @@
   "extends": ["airbnb-base", "prettier"],
   "rules": {
     "dollar-sign/dollar-sign": [2, "ignoreProperties"],
-    "no-plusplus": ["error", { "allowForLoopAfterthoughts": true }]
+    "no-plusplus": ["error", { "allowForLoopAfterthoughts": true }],
+    "no-unused-vars": 1
   }
 }

generators/app/templates/gulp/config.js

@@ -1,6 +1,6 @@
 import util from 'gulp-util';
 
-const production = util.env.production || util.env.prod || false;
+const production = util.env.production || util.env.prod || util.env._.indexOf('build') !== -1 || false;
 const destPath = 'build';
 
 const config = {

generators/app/templates/package.json

@@ -46,7 +46,6 @@
     "gulp-git": "^2.9.0",
     "lost": "^8.3.1",
     "postcss-csso": "^3.0.0",
-    "babel-eslint": "^7.2.3",
     "gulp-postcss": "^8.0.0",<% if (css === 'postcss') { %>
     "gulp-sass-to-postcss-mixins": "0.0.3",
     "postcss": "^8.0.0",
@@ -82,10 +81,8 @@
     "gulp-cheerio": "^0.6.3",
     "gulp-changed": "^3.2.0",
     "gulp-svgstore": "^7.0.1",
-    "through2": "^3.0.1",
-    "gulp-consolidate": "^0.2.0",<% } %><% if (svgo) { %>
+    "through2": "^3.0.1",<% } %><% if (svgo) { %>
     "gulp-svgmin": "^1.2.0",<% } %><% if (templates) { %>
-    "gulp-changed": "^1.3.0",
     "gulp-front-matter": "^1.3.0",
     "gulp-prettify": "^0.5.0",<% } %><% if (templates === 'nunjucks')  { %>
     "gulp-nunjucks-render": "^2.2.2",<% } %><% if (templates === 'swig') { %>
@@ -98,7 +95,6 @@
     "webpack-cli": "^3.3.0",
     "glslify-loader": "^2.0.0",
     "raw-loader": "^1.0.0",
-    "babel-runtime": "^5.0.0",
     "require-yaml": "^0.0.1",
     "lodash": "^4.17.11"
   }

generators/app/templates/webpack.config.js

@@ -1,6 +1,5 @@
 const webpack = require('webpack');
 const path = require('path');
-const util = require('gulp-util');
 const config = require('./gulp/config');
 const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;
 

generators/app/writing.js

@@ -24,6 +24,7 @@ module.exports = function () {
   this.fs.copy(this.templatePath('gitignore'), '.gitignore');
   this.fs.copy(this.templatePath('editorconfig'), '.editorconfig');
   this.fs.copy(this.templatePath('eslintrc'), '.eslintrc');
+  this.fs.copy(this.templatePath('eslintignore'), '.eslintignore');
   this.fs.copy(this.templatePath('htmlhintrc'), '.htmlhintrc');
   this.fs.copy(this.templatePath('sass-lint.yml'), '.sass-lint.yml');
   this.fs.copy(this.templatePath('stylelintrc'), '.stylelintrc');