Fix inspection warnings.

sheabunge · sheabunge · commit db8daf6cb927 · 2025-08-20T11:17:49.000+10:00
diff --git a/src/js/components/EditorSidebar/EditorSidebar.tsx b/src/js/components/EditorSidebar/EditorSidebar.tsx
@@ -1,4 +1,4 @@
-import React, { Dispatch, SetStateAction } from 'react'
+import React from 'react'
 import { Spinner } from '@wordpress/components'
 import { isRTL } from '@wordpress/i18n'
 import { useSnippetForm } from '../../hooks/useSnippetForm'
@@ -16,6 +16,7 @@ import { ActivationSwitch } from './controls/ActivationSwitch'
 import { DeleteButton } from './actions/DeleteButton'
 import { PriorityInput } from './controls/PriorityInput'
 import { RTLControl } from './controls/RTLControl'
+import type { Dispatch, SetStateAction } from 'react'
 
 export interface EditorSidebarProps {
 	setIsUpgradeDialogOpen: Dispatch<SetStateAction<boolean>>
diff --git a/src/js/components/EditorSidebar/controls/PriorityInput.tsx b/src/js/components/EditorSidebar/controls/PriorityInput.tsx
@@ -1,5 +1,5 @@
 import React from 'react'
-import { __, _x } from '@wordpress/i18n'
+import { __ } from '@wordpress/i18n'
 import { useSnippetForm } from '../../../hooks/useSnippetForm'
 import { Tooltip } from '../../common/Tooltip'
 
diff --git a/src/js/components/common/Badge.tsx b/src/js/components/common/Badge.tsx
@@ -1,5 +1,6 @@
-import React, { ReactNode } from 'react'
+import React from 'react'
 import classnames from 'classnames'
+import type { ReactNode } from 'react'
 import type { SnippetType } from '../../types/Snippet'
 
 export type BadgeName = SnippetType | 'core' | 'pro' | 'ai' | 'cloud' | 'bundles' | 'cloud_search' | 'beta'
@@ -22,7 +23,5 @@ export const Badge: React.FC<BadgeProps> = ({ name, small, inverted, children })
 	<span className={classnames('badge', `${name}-badge`, { 'small-badge': small, 'inverted-badge': inverted })}>
 		{badgeIcons[name]
 			? <span className={`dashicons dashicons-${badgeIcons[name]}`} />
-			: children ?
-				children
-				: name}
+			: children ?? name}
 	</span>
diff --git a/src/js/components/common/CopyToClipboardButton.tsx b/src/js/components/common/CopyToClipboardButton.tsx
@@ -1,8 +1,9 @@
 import { Spinner } from '@wordpress/components'
 import { __ } from '@wordpress/i18n'
 import React, { useState } from 'react'
-import { Button, ButtonProps } from './Button'
+import { Button } from './Button'
 import { CopyIcon } from './icons/CopyIcon'
+import type { ButtonProps } from './Button'
 
 const TIMEOUT = 1500
 
diff --git a/src/js/hooks/useAxios.ts b/src/js/hooks/useAxios.ts
diff --git a/src/js/services/manage/requests.ts b/src/js/services/manage/requests.ts
@@ -1,5 +1,5 @@
-import { SnippetSchema } from '../../types/schema/SnippetSchema'
 import { isNetworkAdmin } from '../../utils/screen'
+import type { SnippetSchema } from '../../types/schema/SnippetSchema'
 import type { Snippet, SnippetScope } from '../../types/Snippet'
 
 export interface ResponseData<T = unknown> {
@@ -46,7 +46,7 @@ export const updateSnippet = (field: keyof Snippet, row: Element, snippet: Parti
 	const updatedSnippet: Partial<SnippetSchema> = {
 		id: parseInt(columnId.textContent, 10),
 		shared_network: null !== /\bshared-network-snippet\b/.exec(row.className),
-		network: snippet.shared_network || isNetworkAdmin(),
+		network: snippet.shared_network ?? isNetworkAdmin(),
 		scope: <SnippetScope | null> row.getAttribute('data-snippet-scope') ?? snippet.scope,
 		...snippet
 	}
diff --git a/src/js/utils/restAPI.ts b/src/js/utils/restAPI.ts
@@ -1,7 +1,6 @@
 import { trimTrailingChar } from './text'
 import type { AxiosRequestConfig } from 'axios'
 
-export const REST_BASE = trimTrailingChar(window.CODE_SNIPPETS?.restAPI.base ?? '', '/')
 export const REST_SNIPPETS_BASE = trimTrailingChar(window.CODE_SNIPPETS?.restAPI.snippets ?? '', '/')
 
 export const REST_API_AXIOS_CONFIG: AxiosRequestConfig = {
diff --git a/src/php/admin-menus/class-edit-menu.php b/src/php/admin-menus/class-edit-menu.php
@@ -12,12 +12,12 @@ class Edit_Menu extends Admin_Menu {
 	/**
 	 * Handle for JavaScript asset file.
 	 */
-	const JS_HANDLE = 'code-snippets-edit-menu';
+	public const JS_HANDLE = 'code-snippets-edit-menu';
 
 	/**
 	 * Handle for CSS asset file.
 	 */
-	const CSS_HANDLE = 'code-snippets-edit';
+	public const CSS_HANDLE = 'code-snippets-edit';
 
 	/**
 	 * The snippet object currently being edited
diff --git a/src/php/admin-menus/class-manage-menu.php b/src/php/admin-menus/class-manage-menu.php
@@ -51,6 +51,7 @@ public function run() {
 
 		add_action( 'admin_menu', array( $this, 'register_upgrade_menu' ), 500 );
 		add_filter( 'set-screen-option', array( $this, 'save_screen_option' ), 10, 3 );
+		add_action( 'admin_enqueue_scripts', [ $this, 'enqueue_menu_css' ] );
 		add_action( 'wp_ajax_update_code_snippet', array( $this, 'ajax_callback' ) );
 	}
 
@@ -99,7 +100,6 @@ public function register_upgrade_menu() {
 		);
 
 		add_action( "load-$hook", [ $this, 'load_upgrade_menu' ] );
-		add_action( 'admin_enqueue_scripts', [ $this, 'enqueue_menu_css' ] );
 	}
 
 	/**
diff --git a/src/php/admin-menus/class-settings-menu.php b/src/php/admin-menus/class-settings-menu.php
@@ -17,7 +17,7 @@ class Settings_Menu extends Admin_Menu {
 	/**
 	 * Settings page name as registered with the Settings API.
 	 */
-	const SETTINGS_PAGE = 'code-snippets';
+	public const SETTINGS_PAGE = 'code-snippets';
 
 	/**
 	 * Constructor
diff --git a/src/php/class-data-item.php b/src/php/class-data-item.php
@@ -226,12 +226,19 @@ public function is_allowed_field( string $field ): bool {
 	 * @param mixed  $value The field value.
 	 *
 	 * @return bool true if the field was set successfully, false if the field name is invalid.
+	 *
+	 * @noinspection PhpDocMissingThrowsInspection
 	 */
 	public function set_field( string $field, $value ): bool {
 		if ( ! $this->is_allowed_field( $field ) ) {
 			return false;
 		}
 
+		/**
+		 * Above is_allowed_field check should bypass exception.
+		 *
+		 * @noinspection PhpUnhandledExceptionInspection
+		 */
 		$this->__set( $field, $value );
 
 		return true;
diff --git a/src/php/class-db.php b/src/php/class-db.php
@@ -12,12 +12,12 @@ class DB {
 	/**
 	 * Unprefixed site-wide table name.
 	 */
-	const TABLE_NAME = 'snippets';
+	public const TABLE_NAME = 'snippets';
 
 	/**
 	 * Unprefixed network-wide table name.
 	 */
-	const MS_TABLE_NAME = 'ms_snippets';
+	public const MS_TABLE_NAME = 'ms_snippets';
 
 	/**
 	 * Side-wide table name.
diff --git a/src/php/class-list-table.php b/src/php/class-list-table.php
@@ -121,7 +121,7 @@ public function __construct() {
 	 *
 	 * @return bool
 	 */
-	protected function is_condition_active( Snippet $condition ) {
+	protected function is_condition_active( Snippet $condition ): bool {
 		return $condition->is_condition()
 		       && isset( $this->active_by_condition[ $condition->id ] )
 		       && count( $this->active_by_condition[ $condition->id ] ) > 0;
diff --git a/src/php/class-plugin.php b/src/php/class-plugin.php
@@ -3,8 +3,6 @@
 namespace Code_Snippets;
 
 use Code_Snippets\Cloud\Cloud_API;
-use Code_Snippets\REST_API\Cloud_REST_API;
-use Code_Snippets\REST_API\Conditions_REST_API;
 use Code_Snippets\REST_API\Snippets_REST_Controller;
 use Evaluation\Evaluate_Content;
 use Evaluation\Evaluate_Functions;
@@ -42,14 +40,14 @@ class Plugin {
 	 *
 	 * @var Evaluate_Functions
 	 */
-	public $evaluate_functions;
+	public Evaluate_Functions $evaluate_functions;
 
 	/**
 	 * Class for evaluating content snippets.
 	 *
 	 * @var Evaluate_Content
 	 */
-	public $evaluate_content;
+	public Evaluate_Content $evaluate_content;
 
 	/**
 	 * Administration area class
diff --git a/src/php/class-snippet.php b/src/php/class-snippet.php
@@ -43,12 +43,12 @@ class Snippet extends Data_Item {
 	/**
 	 * MySQL datetime format (YYYY-MM-DD hh:mm:ss).
 	 */
-	const DATE_FORMAT = 'Y-m-d H:i:s';
+	public const DATE_FORMAT = 'Y-m-d H:i:s';
 
 	/**
 	 * Default value used for a datetime variable.
 	 */
-	const DEFAULT_DATE = '0000-00-00 00:00:00';
+	public const DEFAULT_DATE = '0000-00-00 00:00:00';
 
 	/**
 	 * Constructor function.
diff --git a/src/php/cloud/class-cloud-api.php b/src/php/cloud/class-cloud-api.php
@@ -4,7 +4,6 @@
 
 use Code_Snippets\Snippet;
 use WP_Error;
-use function Code_Snippets\code_snippets;
 use function Code_Snippets\get_snippet_by_cloud_id;
 use function Code_Snippets\get_snippets;
 use function Code_Snippets\save_snippet;
@@ -70,6 +69,8 @@ class Cloud_API {
 	 * Retrieve the Cloud URL from wp-config or fallback to default.
 	 *
 	 * @return string
+	 *
+	 * @noinspection PhpUndefinedConstantInspection
 	 */
 	public static function get_cloud_url(): string {
 		return defined( 'CS_CLOUD_URL' )
@@ -81,6 +82,8 @@ public static function get_cloud_url(): string {
 	 * Retrieve the Cloud API URL from wp-config or fallback to default.
 	 *
 	 * @return string
+	 *
+	 * @noinspection PhpUndefinedConstantInspection
 	 */
 	public static function get_cloud_api_url(): string {
 		return defined( 'CS_CLOUD_API_URL' )
diff --git a/src/php/cloud/list-table-shared-ops.php b/src/php/cloud/list-table-shared-ops.php
@@ -30,16 +30,15 @@ function cloud_lts_display_column_hidden_input( string $column_name, Cloud_Snipp
 /**
  * Process the download snippet action
  *
- * @param string $action         Action - 'download' or 'update'.
- * @param string $source         Source - 'search' or 'cloud'.
- * @param string $snippet        Snippet ID.
- * @param int    $codevault_page The current page of the codevault.
+ * @param string $action  Action - 'download' or 'update'.
+ * @param string $source  Source - 'search' or 'cloud'.
+ * @param string $snippet Snippet ID.
  *
  * @return void
  */
-function cloud_lts_process_download_action( string $action, string $source, string $snippet, int $codevault_page = 0 ) {
+function cloud_lts_process_download_action( string $action, string $source, string $snippet ) {
 	if ( 'download' === $action || 'update' === $action ) {
-		$result = code_snippets()->cloud_api->download_or_update_snippet( $snippet, $source, $action, $codevault_page );
+		$result = code_snippets()->cloud_api->download_or_update_snippet( $snippet, $source, $action );
 
 		if ( $result['success'] ) {
 			$redirect_uri = $result['snippet_id'] ?
diff --git a/src/php/evaluation/class-evaluate-functions.php b/src/php/evaluation/class-evaluate-functions.php
@@ -66,6 +66,8 @@ private function get_currently_editing_snippet(): ?array {
 	 * Check if the plugin is running in safe mode.
 	 *
 	 * @return bool
+	 *
+	 * @noinspection PhpUndefinedConstantInspection
 	 */
 	public function is_safe_mode_active(): bool {
 		return ( defined( 'CODE_SNIPPETS_SAFE_MODE' ) && CODE_SNIPPETS_SAFE_MODE ) ||
diff --git a/src/php/front-end/class-front-end.php b/src/php/front-end/class-front-end.php
@@ -16,22 +16,17 @@ class Front_End {
 	/**
 	 * Name of the shortcode tag for rendering the code source
 	 */
-	const SOURCE_SHORTCODE = 'code_snippet_source';
+	public const SOURCE_SHORTCODE = 'code_snippet_source';
 
 	/**
 	 * Name of the shortcode tag for rendering content snippets
 	 */
-	const CONTENT_SHORTCODE = 'code_snippet';
+	public const CONTENT_SHORTCODE = 'code_snippet';
 
 	/**
 	 * Handle to use for front-end scripts and styles.
 	 */
-	const PRISM_HANDLE = 'code-snippets-prism';
-
-	/**
-	 * Maximum depth for shortcode recursion.
-	 */
-	const MAX_SHORTCODE_DEPTH = 5;
+	public const PRISM_HANDLE = 'code-snippets-prism';
 
 	/**
 	 * Class constructor
diff --git a/src/php/rest-api/class-snippets-rest-controller.php b/src/php/rest-api/class-snippets-rest-controller.php
@@ -16,7 +16,6 @@
 use function Code_Snippets\get_snippet;
 use function Code_Snippets\get_snippets;
 use function Code_Snippets\save_snippet;
-use function Code_Snippets\update_snippet_fields;
 use const Code_Snippets\REST_API_NAMESPACE;
 
 /**
@@ -30,12 +29,12 @@ final class Snippets_REST_Controller extends WP_REST_Controller {
 	/**
 	 * Current API version.
 	 */
-	const VERSION = 1;
+	public const VERSION = 1;
 
 	/**
 	 * The base of this controller's route.
 	 */
-	const BASE_ROUTE = 'snippets';
+	public const BASE_ROUTE = 'snippets';
 
 	/**
 	 * The namespace of this controller's route.
diff --git a/src/php/snippet-ops.php b/src/php/snippet-ops.php
@@ -7,7 +7,6 @@
 
 namespace Code_Snippets;
 
-use Code_Snippets\REST_API\Snippets_REST_Controller;
 use ParseError;
 use function Code_Snippets\Settings\get_self_option;
 use function Code_Snippets\Settings\update_self_option;
@@ -581,6 +580,11 @@ function save_snippet( $snippet ) {
  * @since 2.0.0
  */
 function execute_snippet( string $code, int $id = 0, bool $force = false ) {
+	/**
+	 * Do not continue if safe mode is active.
+	 *
+	 * @noinspection PhpUndefinedConstantInspection
+	 */
 	if ( empty( $code ) || ( ! $force && defined( 'CODE_SNIPPETS_SAFE_MODE' ) && CODE_SNIPPETS_SAFE_MODE ) ) {
 		return false;
 	}
diff --git a/src/php/views/partials/list-table-notices.php b/src/php/views/partials/list-table-notices.php
@@ -14,6 +14,11 @@
  * @var Manage_Menu $this
  */
 
+/**
+ * Constant existence is checked with defined().
+ *
+ * @noinspection PhpUndefinedConstantInspection
+ */
 if ( defined( 'CODE_SNIPPETS_SAFE_MODE' ) && CODE_SNIPPETS_SAFE_MODE ) {
 	?>
 	<div id="message" class="notice notice-error fade is-dismissible">

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ public function run() {`
`51`	`51`
`52`	`52`	`add_action( 'admin_menu', array( $this, 'register_upgrade_menu' ), 500 );`
`53`	`53`	`add_filter( 'set-screen-option', array( $this, 'save_screen_option' ), 10, 3 );`
	`54`	`+ add_action( 'admin_enqueue_scripts', [ $this, 'enqueue_menu_css' ] );`
`54`	`55`	`add_action( 'wp_ajax_update_code_snippet', array( $this, 'ajax_callback' ) );`
`55`	`56`	`}`
`56`	`57`
`@@ -99,7 +100,6 @@ public function register_upgrade_menu() {`
`99`	`100`	`);`
`100`	`101`
`101`	`102`	`add_action( "load-$hook", [ $this, 'load_upgrade_menu' ] );`
`102`		`- add_action( 'admin_enqueue_scripts', [ $this, 'enqueue_menu_css' ] );`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`/**`