Merge pull request #11 from jstumbaugh/allow-for-multi-select-filters

Allow for multi-select filters

Author: tf

README.md

@@ -50,6 +50,15 @@ This also works for filters:
    end
 ```
 
+By default, you can only select one at a time for a filter. You can
+specify a multi-select with:
+
+```ruby
+   ActiveAdmin.register Product do
+     filter(:category, as: :searchable_select, multiple: true)
+   end
+```
+
 ### Fetching Options via Ajax
 
 For large collections, rendering the whole set of options can be to

lib/activeadmin/searchable_select/select_input_extension.rb

@@ -57,23 +57,23 @@ def all_options_collection
       end
 
       def selected_value_collection
-        [selected_value_option].compact
-      end
-
-      def selected_value_option
-        option_for_record(selected_record) if selected_record
+        selected_records.collect { |s| option_for_record(s) }
       end
 
       def option_for_record(record)
         [option_collection.display_text(record), record.id]
       end
 
-      def selected_record
-        @selected_record ||=
-          selected_value && option_collection_scope.find_by_id(selected_value)
+      def selected_records
+        @selected_records ||=
+          if selected_values
+            option_collection_scope.where(id: selected_values)
+          else
+            []
+          end
       end
 
-      def selected_value
+      def selected_values
         @object.send(input_name) if @object
       end
 

spec/features/filter_input_spec.rb

@@ -188,4 +188,54 @@
                                              text: 'Travel')
     end
   end
+
+  describe 'with the multiple option set to true' do
+    before(:each) do
+      ActiveAdminHelpers.setup do
+        ActiveAdmin.register(Category) do
+          searchable_select_options(scope: Category, text_attribute: :name)
+        end
+
+        ActiveAdmin.register(Post) do
+          filter(:category,
+                 as: :searchable_select,
+                 ajax: true,
+                 multiple: true)
+        end
+      end
+    end
+
+    it 'renders select input with searchable-select-input css class and the multiple attribute' do
+      get '/admin/posts'
+
+      expect(response.body).to have_selector("select.searchable-select-input[multiple='multiple']")
+    end
+
+    it 'does not render options statically' do
+      Category.create!(name: 'Travel')
+
+      get '/admin/posts'
+
+      expect(response.body).not_to have_selector('.searchable-select-input option',
+                                                 text: 'Travel')
+    end
+
+    it 'sets data-ajax-url attribute' do
+      get '/admin/posts'
+
+      expect(response.body).to have_selector('.searchable-select-input[data-ajax-url]')
+    end
+
+    it 'renders the filter for multiple values selected' do
+      category1 = Category.create!(name: 'Travel')
+      category2 = Category.create!(name: 'Leisure')
+
+      get "/admin/posts?q[category_id_in][]=#{category1.id}&q[category_id_in][]=#{category2.id}"
+
+      expect(response.body).to have_selector('.searchable-select-input option[selected]',
+                                             text: 'Travel')
+      expect(response.body).to have_selector('.searchable-select-input option[selected]',
+                                             text: 'Leisure')
+    end
+  end
 end