|
| 1 | +<?php |
| 2 | + |
| 3 | +use CodingLibs\MFA\MFA; |
| 4 | +use CodingLibs\MFA\Contracts\MfaChannel; |
| 5 | +use CodingLibs\MFA\Models\MfaChallenge; |
| 6 | +use Illuminate\Contracts\Auth\Authenticatable; |
| 7 | + |
| 8 | +class ChallengeGenerationTestFakeUser implements Authenticatable |
| 9 | +{ |
| 10 | + public function __construct(public int|string $id, public ?string $email = null) {} |
| 11 | + public function getAuthIdentifierName() { return 'id'; } |
| 12 | + public function getAuthIdentifier() { return $this->id; } |
| 13 | + public function getAuthPassword() { return ''; } |
| 14 | + public function getAuthPasswordName() { return 'password'; } |
| 15 | + public function getRememberToken() { return null; } |
| 16 | + public function setRememberToken($value): void {} |
| 17 | + public function getRememberTokenName() { return 'remember_token'; } |
| 18 | + public function getEmailForVerification() { return $this->email; } |
| 19 | +} |
| 20 | + |
| 21 | +class ChallengeGenerationTestChannel implements MfaChannel |
| 22 | +{ |
| 23 | + public ?string $lastCode = null; |
| 24 | + public int $sendCallCount = 0; |
| 25 | + |
| 26 | + public function __construct(protected array $config = []) {} |
| 27 | + |
| 28 | + public function getName(): string { return 'test_channel'; } |
| 29 | + |
| 30 | + public function send(Authenticatable $user, string $code, array $options = []): void |
| 31 | + { |
| 32 | + $this->lastCode = $code; |
| 33 | + $this->sendCallCount++; |
| 34 | + } |
| 35 | +} |
| 36 | + |
| 37 | +it('generates challenge without sending when send=false', function () { |
| 38 | + $user = new ChallengeGenerationTestFakeUser(3001, 'user@example.com'); |
| 39 | + $mfa = app(MFA::class); |
| 40 | + |
| 41 | + $channel = new ChallengeGenerationTestChannel(); |
| 42 | + $mfa->registerChannel($channel); |
| 43 | + |
| 44 | + $challenge = $mfa->issueChallenge($user, 'test_channel', false); |
| 45 | + |
| 46 | + expect($challenge)->toBeInstanceOf(MfaChallenge::class); |
| 47 | + expect($challenge->code)->toBeString()->toHaveLength(6); |
| 48 | + expect($challenge->method)->toBe('test_channel'); |
| 49 | + expect($challenge->expires_at)->not->toBeNull(); |
| 50 | + |
| 51 | + // Channel should not have been called |
| 52 | + expect($channel->sendCallCount)->toBe(0); |
| 53 | + expect($channel->lastCode)->toBeNull(); |
| 54 | +}); |
| 55 | + |
| 56 | +it('generates challenge and sends when send=true (default behavior)', function () { |
| 57 | + $user = new ChallengeGenerationTestFakeUser(3002, 'user@example.com'); |
| 58 | + $mfa = app(MFA::class); |
| 59 | + |
| 60 | + $channel = new ChallengeGenerationTestChannel(); |
| 61 | + $mfa->registerChannel($channel); |
| 62 | + |
| 63 | + $challenge = $mfa->issueChallenge($user, 'test_channel', true); |
| 64 | + |
| 65 | + expect($challenge)->toBeInstanceOf(MfaChallenge::class); |
| 66 | + expect($challenge->code)->toBeString()->toHaveLength(6); |
| 67 | + |
| 68 | + // Channel should have been called |
| 69 | + expect($channel->sendCallCount)->toBe(1); |
| 70 | + expect($channel->lastCode)->toBe($challenge->code); |
| 71 | +}); |
| 72 | + |
| 73 | +it('generates challenge and sends by default (backward compatibility)', function () { |
| 74 | + $user = new ChallengeGenerationTestFakeUser(3003, 'user@example.com'); |
| 75 | + $mfa = app(MFA::class); |
| 76 | + |
| 77 | + $channel = new ChallengeGenerationTestChannel(); |
| 78 | + $mfa->registerChannel($channel); |
| 79 | + |
| 80 | + $challenge = $mfa->issueChallenge($user, 'test_channel'); |
| 81 | + |
| 82 | + expect($challenge)->toBeInstanceOf(MfaChallenge::class); |
| 83 | + expect($challenge->code)->toBeString()->toHaveLength(6); |
| 84 | + |
| 85 | + // Channel should have been called (default behavior) |
| 86 | + expect($channel->sendCallCount)->toBe(1); |
| 87 | + expect($channel->lastCode)->toBe($challenge->code); |
| 88 | +}); |
| 89 | + |
| 90 | +it('generateChallenge creates challenge without sending', function () { |
| 91 | + $user = new ChallengeGenerationTestFakeUser(3004, 'user@example.com'); |
| 92 | + $mfa = app(MFA::class); |
| 93 | + |
| 94 | + $channel = new ChallengeGenerationTestChannel(); |
| 95 | + $mfa->registerChannel($channel); |
| 96 | + |
| 97 | + $challenge = $mfa->generateChallenge($user, 'test_channel'); |
| 98 | + |
| 99 | + expect($challenge)->toBeInstanceOf(MfaChallenge::class); |
| 100 | + expect($challenge->code)->toBeString()->toHaveLength(6); |
| 101 | + expect($challenge->method)->toBe('test_channel'); |
| 102 | + expect($challenge->expires_at)->not->toBeNull(); |
| 103 | + |
| 104 | + // Channel should never be called with generateChallenge |
| 105 | + expect($channel->sendCallCount)->toBe(0); |
| 106 | + expect($channel->lastCode)->toBeNull(); |
| 107 | +}); |
| 108 | + |
| 109 | +it('generateChallenge returns null for unknown channel', function () { |
| 110 | + $user = new ChallengeGenerationTestFakeUser(3005, 'user@example.com'); |
| 111 | + $mfa = app(MFA::class); |
| 112 | + |
| 113 | + $challenge = $mfa->generateChallenge($user, 'unknown_channel'); |
| 114 | + |
| 115 | + expect($challenge)->toBeNull(); |
| 116 | +}); |
| 117 | + |
| 118 | +it('issueChallenge with send=false returns null for unknown channel', function () { |
| 119 | + $user = new ChallengeGenerationTestFakeUser(3006, 'user@example.com'); |
| 120 | + $mfa = app(MFA::class); |
| 121 | + |
| 122 | + $challenge = $mfa->issueChallenge($user, 'unknown_channel', false); |
| 123 | + |
| 124 | + expect($challenge)->toBeNull(); |
| 125 | +}); |
| 126 | + |
| 127 | +it('can manually send code after generating challenge', function () { |
| 128 | + $user = new ChallengeGenerationTestFakeUser(3007, 'user@example.com'); |
| 129 | + $mfa = app(MFA::class); |
| 130 | + |
| 131 | + $channel = new ChallengeGenerationTestChannel(); |
| 132 | + $mfa->registerChannel($channel); |
| 133 | + |
| 134 | + // Generate challenge without sending |
| 135 | + $challenge = $mfa->generateChallenge($user, 'test_channel'); |
| 136 | + expect($challenge)->toBeInstanceOf(MfaChallenge::class); |
| 137 | + expect($channel->sendCallCount)->toBe(0); |
| 138 | + |
| 139 | + // Manually send the code |
| 140 | + $channel->send($user, $challenge->code); |
| 141 | + expect($channel->sendCallCount)->toBe(1); |
| 142 | + expect($channel->lastCode)->toBe($challenge->code); |
| 143 | +}); |
| 144 | + |
| 145 | +it('generated challenge can be verified normally', function () { |
| 146 | + $user = new ChallengeGenerationTestFakeUser(3008, 'user@example.com'); |
| 147 | + $mfa = app(MFA::class); |
| 148 | + |
| 149 | + $channel = new ChallengeGenerationTestChannel(); |
| 150 | + $mfa->registerChannel($channel); |
| 151 | + |
| 152 | + // Generate challenge without sending |
| 153 | + $challenge = $mfa->generateChallenge($user, 'test_channel'); |
| 154 | + expect($challenge)->toBeInstanceOf(MfaChallenge::class); |
| 155 | + |
| 156 | + // Verify the challenge works normally |
| 157 | + $verified = $mfa->verifyChallenge($user, 'test_channel', $challenge->code); |
| 158 | + expect($verified)->toBeTrue(); |
| 159 | + |
| 160 | + // Check that the challenge was consumed |
| 161 | + $challenge->refresh(); |
| 162 | + expect($challenge->consumed_at)->not->toBeNull(); |
| 163 | + expect($mfa->isEnabled($user, 'test_channel'))->toBeTrue(); |
| 164 | +}); |
0 commit comments