fixing

anwarx4u · anwarx4u · commit a1bbf90ca490 · 2025-10-01T13:52:02.000+06:00
diff --git a/src/Totp/GoogleTotp.php b/src/Totp/GoogleTotp.php
@@ -4,10 +4,17 @@
 
 class GoogleTotp
 {
-    public static function generateSecret(int $length = 20): string
+    public static function generateSecret(int $length = 16): string
     {
-        $randomBytes = random_bytes($length);
-        return rtrim(strtr(base64_encode($randomBytes), '+/', 'AB'), '=');
+        $alphabet = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ234567';
+        $secret = '';
+        $alphabetLength = strlen($alphabet);
+        
+        for ($i = 0; $i < $length; $i++) {
+            $secret .= $alphabet[random_int(0, $alphabetLength - 1)];
+        }
+        
+        return $secret;
     }
 
     public static function buildOtpAuthUrl(string $secret, string $label, string $issuer, int $digits = 6, int $period = 30): string

Original file line number	Diff line number	Diff line change
`@@ -4,10 +4,17 @@`
`4`	`4`
`5`	`5`	`class GoogleTotp`
`6`	`6`	`{`
`7`		`- public static function generateSecret(int $length = 20): string`
	`7`	`+ public static function generateSecret(int $length = 16): string`
`8`	`8`	`{`
`9`		`- $randomBytes = random_bytes($length);`
`10`		`- return rtrim(strtr(base64_encode($randomBytes), '+/', 'AB'), '=');`
	`9`	`+ $alphabet = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ234567';`
	`10`	`+ $secret = '';`
	`11`	`+ $alphabetLength = strlen($alphabet);`
	`12`	`+`
	`13`	`+ for ($i = 0; $i < $length; $i++) {`
	`14`	`+ $secret .= $alphabet[random_int(0, $alphabetLength - 1)];`
	`15`	`+ }`
	`16`	`+`
	`17`	`+ return $secret;`
`11`	`18`	`}`
`12`	`19`
`13`	`20`	`public static function buildOtpAuthUrl(string $secret, string $label, string $issuer, int $digits = 6, int $period = 30): string`