Github Angola Users #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entrega do desafio relativo ao calculo da idade de uma pessoa, passando o seu ano de nascimento como parâmetro.
JoseCage
suggested changes
Sep 14, 2017
tests/testAgeCalculator.php
Outdated
| </form> | ||
|
|
||
|
|
||
| <?php |
There was a problem hiding this comment.
Referente ao teste, a classe não deve contar html. O html pode estar por exemplo numa página /app/github/index.php. Porque nessa classe dentro de tests deve ser feito o teste usando PHPUnit
There was a problem hiding this comment.
@guimar86 falta ajustes para o teste passar no StyleCI.
Dá uma olhada na analise do StyleCI para entender onde ajustar..
JoseCage
suggested changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desafio para aquisição da lista de utilizadores do GitHub em Angola