Add networkAccess Permission?

[AndroidKitKat]

I think it'd be a good idea to prevent plugins from using the network unless explicitly allowed. Just my idea.

[colfrog]

Network access permissions are a good idea, but I'm not sure how I would do this right now. The permissions system is currently based on what functions and objects are allowed in the module's global context. If no networking functions are in its context, the module can't (in theory) do networking, so the hasRequire permission takes care of that. However, if the module needs access to the require function, but doesn't need the network, I'm not sure how I would enforce the constraint.

As far as I'm aware, node.js doesn't have a way to entirely block networking for a vm instance.

Ideas of how to do this are welcome. Maybe @flotwig can help?

[flotwig]

The only way I can think of would be to override built-in methods on http, tls, net, https, http2, etc... but you'd almost certainly miss a reference somewhere and have a leak anyways, so why bother trying to have a false sense of security.

I don't see why this is necessary though. I'm kind of confused why there are "permissions" for the modules, why would you be running untrusted code?

[colfrog]

The way jesi uses vm, supporting remote modules would actually be pretty simple, and webassembly support is also planned. So having a way to manage a module's access to the rest of jesi without necessarily having access to the module's code was a priority from the start.