fix(mmserver): make missing hardware encode support a hard error

Author: colinmarc

mm-server/src/main.rs

@@ -212,12 +212,6 @@ fn preflight_checks(cfg: &config::Config, vk: &vulkan::VkContext) -> anyhow::Res
         cfg.data_home.display(),
     ))?;
 
-    if !vk.device_info.supports_h264 || !vk.device_info.supports_h265 {
-        warn!(
-            "no/partial support for hardware encoding! performance may be significantly decreased"
-        );
-    }
-
     // Check for Ubuntu's restrictions on rootless containers.
     if sysctl("apparmor_restrict_unprivileged_unconfined")
         || sysctl("apparmor_restrict_unprivileged_userns")

mm-server/src/vulkan.rs

@@ -234,7 +234,7 @@ impl VkDeviceInfo {
 
         for ext in selected_extensions.iter() {
             if !contains_extension(&available_extensions, ext) {
-                return Err(anyhow::anyhow!("extension {:?} not available", ext));
+                bail!("extension {:?} not available", ext);
             }
         }
 
@@ -273,6 +273,10 @@ impl VkDeviceInfo {
             }
         }
 
+        if !supports_av1 && !supports_h265 && !supports_h264 {
+            bail!("hardware encode extensions not available");
+        }
+
         // We want HOST_CACHED | HOST_COHERENT, but we can make do with just
         // HOST_VISIBLE.
         let memory_props = unsafe { instance.get_physical_device_memory_properties(device) };