%version% in commit message is not getting substituted

[mankel08]

Hi,

We are using semver-resource v1.4.0. We have defined the resource as follows.

- name: dev-semver
  type: semver
  icon: pound-box
  source:
    driver: git
    uri: <some-git-repo>
    branch: master
    commit_message: "semver bump to %version%"
    file: <some-path>/dev

We do a put: dev-semver. The expectation is that value in a file <some-path>/dev would get updated with a commit message semver bump to 1.0.1 . This works perfectly fine when the resource does not do/need a rebase of the git repo.

However, when the put: dev-semver does an automatic rebase before pushing; the %version% is not substituted and remains as %version% in the commit message. Value in the file is updated correctly, only the commit message has issues.
Ex: semver bump to %version%

[taylorsilva]

Here's where we create the commit message:

semver-resource/driver/git.go

Lines 347 to 356 in 38888c4

	var commitMessage string
	if driver.CommitMessage == "" {
	commitMessage = "bump to " + newVersion.String()
	} else {
	commitMessage = strings.Replace(driver.CommitMessage, "%version%", newVersion.String(), -1)
	commitMessage = strings.Replace(commitMessage, "%file%", driver.File, -1)
	}
	gitCommit := exec.Command("git", "commit", "-m", commitMessage)
	gitCommit.Dir = gitRepoDir

Really weird, I don't see how rebasing would cause the commit message to have %version% in it. The automatic rebasing would happen after we make the commit. git has no way of knowing about the the original value from driver.CommitMessage since we never pass that value to it