From 2d8387a45d693e1fcef9650a05c7b985795ae01c Mon Sep 17 00:00:00 2001 From: Aditya Savara <39929571+AdityaSavara@users.noreply.github.com> Date: Mon, 26 May 2025 22:57:01 -0400 Subject: [PATCH 1/3] Clarifying Step by Step instructions for staged-recipes contribution Two changes were made: (1) It was clarified that the contributor should make a new branch on their fork (not the conda-forge fork) (2) A step was added at the end to actually make the pull request to the conda-forge main branch of staged-recipes. --- docs/maintainer/adding_pkgs.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/maintainer/adding_pkgs.md b/docs/maintainer/adding_pkgs.md index 580b025c99e..a7ba59db8cb 100644 --- a/docs/maintainer/adding_pkgs.md +++ b/docs/maintainer/adding_pkgs.md @@ -89,7 +89,7 @@ In case you are building your first recipe using conda-forge, a step-by-step ins detail, see [Build from tarballs, not repos](#tarballs-no-repos)). 2. Fork and clone the [staged-recipes](https://github.com/conda-forge/staged-recipes) repository from GitHub. -3. Checkout a new branch from the staged-recipes `main` branch. +3. On your fork of staged-recipes, create a new branch from the `main` branch. 4. Through CLI, cd inside the ‘staged-recipes/recipes' directory. 5. Within your forked copy, create a new folder in the recipes folder for your package (i.e, `...staged-recipes/recipes/`) 6. Copy [meta.yaml](https://github.com/conda-forge/staged-recipes/blob/master/recipes/example/meta.yaml) from the example directory. @@ -104,6 +104,7 @@ In case you are building your first recipe using conda-forge, a step-by-step ins 9. Be sure to fill in the `test` section. The simplest test will simply test that the module can be imported, as described in the example. 10. Remove all irrelevant comments in the `meta.yaml` file. +11. Double check the checklist (below) and then make a pull request from the new branch on your fork to the main branch of [staged-recipes](https://github.com/conda-forge/staged-recipes) :::tip From b69a8a924276ee04e016afccd0bdfdaf3fc211a3 Mon Sep 17 00:00:00 2001 From: Aditya Savara <39929571+AdityaSavara@users.noreply.github.com> Date: Mon, 26 May 2025 23:01:14 -0400 Subject: [PATCH 2/3] changed "PR" to "pull request (PR) changed "PR" to "pull request (PR) --- docs/maintainer/adding_pkgs.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/maintainer/adding_pkgs.md b/docs/maintainer/adding_pkgs.md index a7ba59db8cb..980a58af3f2 100644 --- a/docs/maintainer/adding_pkgs.md +++ b/docs/maintainer/adding_pkgs.md @@ -12,7 +12,7 @@ The contribution process can be broken down into three steps: - Step 1. Staging process (add recipe and license). - With the help of [the staging process](#creating-recipes), add a package's recipe and license to the [staged-recipes repository](https://github.com/conda-forge/staged-recipes) and create a PR. + With the help of [the staging process](#creating-recipes), add a package's recipe and license to the [staged-recipes repository](https://github.com/conda-forge/staged-recipes) and create a pull request (PR). - Step 2. Post staging process. @@ -131,7 +131,7 @@ curl -sL https://github.com/username/reponame/archive/vX.X.X.tar.gz | openssl sh ### Feedback and revision -Once you finished your PR, all you have to do is wait for feedback from our review team. +Once you finished your pull request PR, all you have to do is wait for feedback from our review team. The review team will assist you by pointing out improvements and answering questions. Once the package is ready, the reviewers will approve and merge your pull request. From a35b0d59dfa72bc42ca6cec9224aec55ca1531b3 Mon Sep 17 00:00:00 2001 From: Aditya Savara <39929571+AdityaSavara@users.noreply.github.com> Date: Mon, 26 May 2025 23:07:26 -0400 Subject: [PATCH 3/3] Added a link to the glossary for pull request Added a link to the glossary for pull request --- docs/maintainer/adding_pkgs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/maintainer/adding_pkgs.md b/docs/maintainer/adding_pkgs.md index 980a58af3f2..d660008a2d2 100644 --- a/docs/maintainer/adding_pkgs.md +++ b/docs/maintainer/adding_pkgs.md @@ -12,7 +12,7 @@ The contribution process can be broken down into three steps: - Step 1. Staging process (add recipe and license). - With the help of [the staging process](#creating-recipes), add a package's recipe and license to the [staged-recipes repository](https://github.com/conda-forge/staged-recipes) and create a pull request (PR). + With the help of [the staging process](#creating-recipes), add a package's recipe and license to the [staged-recipes repository](https://github.com/conda-forge/staged-recipes) and create a pull request ( [PR](../glossary.md#pr) ). - Step 2. Post staging process.