Skip to content

Fix how NSIS amends PATH on Windows #623

@jaimergp

Description

@jaimergp

https://nsis.sourceforge.io/Setting_Environment_Variables has a big warning about this:

WARNING: Strings longer than ${NSIS_MAX_STRLEN} will get truncated/corrupted. Do NOT use this function to update %PATH%, use the EnVar_plug-in instead.

... and that's how it's being done right now. Unclear if $INSTDIR and $0 get expanded for the count, but I assume they do and on (very?) long paths, this might be an issue. This is worth an investigation and, if we need this, we would have to add the EnVar plugin to the nsis builds on conda-forge and defaults.

Metadata

Metadata

Assignees

No one assigned

    Labels

    os::windowsrelevant to Windowsstale[bot] marked as stale due to inactivitystale::recovered[bot] recovered after being marked as stale

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions