Refactor respond JSON

minhduc140583 · minhduc140583 · commit a1e1b5d80eab · 2021-10-10T17:11:51.000+07:00
diff --git a/log.go b/log.go
@@ -7,10 +7,12 @@ import (
 )
 
 func respond(w http.ResponseWriter, r *http.Request, code int, result interface{}, writeLog func(context.Context, string, string, bool, string) error, resource string, action string, success bool, desc string) {
-	response, _ := json.Marshal(result)
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(code)
-	w.Write(response)
+	err := json.NewEncoder(w).Encode(result)
+	if err != nil {
+		http.Error(w, err.Error(), http.StatusInternalServerError)
+	}
 	if writeLog != nil {
 		writeLog(r.Context(), resource, action, success, desc)
 	}

Original file line number	Diff line number	Diff line change
`@@ -7,10 +7,12 @@ import (`
`7`	`7`	`)`
`8`	`8`
`9`	`9`	`func respond(w http.ResponseWriter, r *http.Request, code int, result interface{}, writeLog func(context.Context, string, string, bool, string) error, resource string, action string, success bool, desc string) {`
`10`		`- response, _ := json.Marshal(result)`
`11`	`10`	`w.Header().Set("Content-Type", "application/json")`
`12`	`11`	`w.WriteHeader(code)`
`13`		`- w.Write(response)`
	`12`	`+ err := json.NewEncoder(w).Encode(result)`
	`13`	`+ if err != nil {`
	`14`	`+ http.Error(w, err.Error(), http.StatusInternalServerError)`
	`15`	`+ }`
`14`	`16`	`if writeLog != nil {`
`15`	`17`	`writeLog(r.Context(), resource, action, success, desc)`
`16`	`18`	`}`