Skip to content

Commit 145e651

Browse files
authored
Merge pull request #451 from codomposer/fix/memory_leak_appheader
fix memory leak in app header
2 parents 0589d8e + a6b2a9c commit 145e651

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/components/AppHeader.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,12 @@ const AppHeader = () => {
3636
const sidebarShow = useSelector((state) => state.sidebarShow)
3737

3838
useEffect(() => {
39-
document.addEventListener('scroll', () => {
39+
const handleScroll = () => {
4040
headerRef.current &&
4141
headerRef.current.classList.toggle('shadow-sm', document.documentElement.scrollTop > 0)
42-
})
42+
}
43+
document.addEventListener('scroll', handleScroll)
44+
return () => document.removeEventListener('scroll', handleScroll)
4345
}, [])
4446

4547
return (

0 commit comments

Comments
 (0)