Ignore frontend instance on connect error (#2569)

annanay25 · web-flow · commit 7d1ee7f63870 · 2020-05-07T15:29:20.000+02:00
* Ignore frontend instance on connect error

Signed-off-by: Annanay &lt;annanayagarwal@gmail.com&gt;

* Update CHANGELOG

Signed-off-by: Annanay &lt;annanayagarwal@gmail.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -59,6 +59,7 @@
 * [BUGFIX] Fixed `version`, `revision` and `branch` labels exported by the `cortex_build_info` metric. #2468
 * [BUGFIX] QueryFrontend: fixed a situation where HTTP error is ignored and an incorrect status code is set. #2483
 * [BUGFIX] QueryFrontend: fixed a situation where span context missed when downstream_url is used. #2539
+* [BUGFIX] Querier: Fixed a situation where querier would crash because of an unresponsive frontend instance. #2569
 
 ## 1.0.0 / 2020-04-02
 
diff --git a/pkg/querier/frontend/worker.go b/pkg/querier/frontend/worker.go
@@ -117,6 +117,7 @@ func (w *worker) watchDNSLoop(servCtx context.Context) error {
 				client, err := w.connect(servCtx, update.Addr)
 				if err != nil {
 					level.Error(w.log).Log("msg", "error connecting", "addr", update.Addr, "err", err)
+					continue
 				}
 
 				w.managers[update.Addr] = newFrontendManager(servCtx, w.log, w.server, client, w.cfg.GRPCClientConfig)

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,7 @@ func (w *worker) watchDNSLoop(servCtx context.Context) error {`
`117`	`117`	`client, err := w.connect(servCtx, update.Addr)`
`118`	`118`	`if err != nil {`
`119`	`119`	`level.Error(w.log).Log("msg", "error connecting", "addr", update.Addr, "err", err)`
	`120`	`+ continue`
`120`	`121`	`}`
`121`	`122`
`122`	`123`	`w.managers[update.Addr] = newFrontendManager(servCtx, w.log, w.server, client, w.cfg.GRPCClientConfig)`