Omit empty for error and error types (#5954)

Author: yeya24

CHANGELOG.md

@@ -4,7 +4,7 @@
 
 ## 1.17.1 2024-05-20
 
-* [CHANGE] Query Frontend/Ruler: Omit empty data field in API response. #5953
+* [CHANGE] Query Frontend/Ruler: Omit empty data, errorType and error fields in API response. #5953 #5954
 
 ## 1.17.0 2024-04-30
 

pkg/ruler/api_test.go

@@ -337,7 +337,7 @@ func TestRuler_DeleteNamespace(t *testing.T) {
 
 	router.ServeHTTP(w, req)
 	require.Equal(t, http.StatusAccepted, w.Code)
-	require.Equal(t, "{\"status\":\"success\",\"errorType\":\"\",\"error\":\"\"}", w.Body.String())
+	require.Equal(t, "{\"status\":\"success\"}", w.Body.String())
 
 	// On Partial failures
 	req = requestFor(t, http.MethodDelete, "https://localhost:8080/api/v1/rules/namespace2", nil, "user1")
@@ -430,7 +430,7 @@ rules:
 - record: up_rule
   expr: up{}
 `,
-			output: "{\"status\":\"success\",\"errorType\":\"\",\"error\":\"\"}",
+			output: "{\"status\":\"success\"}",
 		},
 		{
 			name:   "when exceeding the rule group limit after sending the first group",
@@ -490,7 +490,7 @@ rules:
   expr: |2+
     up{}
 `,
-			output: "{\"status\":\"success\",\"errorType\":\"\",\"error\":\"\"}",
+			output: "{\"status\":\"success\"}",
 		},
 		{
 			name:   "when pushing group that CANNOT be safely converted from RuleGroupDesc to RuleGroup yaml",

pkg/util/api/response.go

@@ -20,8 +20,8 @@ const (
 type Response struct {
 	Status    string       `json:"status"`
 	Data      interface{}  `json:"data,omitempty"`
-	ErrorType v1.ErrorType `json:"errorType"`
-	Error     string       `json:"error"`
+	ErrorType v1.ErrorType `json:"errorType,omitempty"`
+	Error     string       `json:"error,omitempty"`
 	Warnings  []string     `json:"warnings,omitempty"`
 }