Skip to content

Improve locking code in FunctionsController #79

@jongeorge1

Description

@jongeorge1

During a review of #78, @mwadams raised concerns about the locking code in FunctionsController.

I realise this hasn't changed, but this should probably be a lock with a timeout to stop the specs hanging for ever (until the specrunner times out) in the event of a failure or deadlock.
Fortunately @idg10 has a TimedLock which may even have made it into Corvus.

and

Similarly it feels like we should have timeouts on these. I also worry about locking these actual objects rather than proxies for them. Deadlocks can occur if the implementation decides to take locks on itself internally at some point.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions