Support repo-level stats in cbbackupmgr archives #125
Conversation
dave-finlay
left a comment
dave-finlay
left a comment
There was a problem hiding this comment.
Hi Saf: the change is pretty straightforward and it works -- at least it did when I got the correct version of cbmstatparser built. :-)
One thing that wasn't clear to me was the distinction between "archive-level" stats and "repo-level" stats. Archive-level makes sense when these were the only places that stats could reside in an archive (under logs/stats) but now because stats may be found under any file path that matches*/logs/stats basically there are lots of "archive-level" stats.
Is "repo" a backup repository -- and is it the case that backup archives can now include backup information from multiple different backup repostories?
dave-finlay
left a comment
dave-finlay
left a comment
There was a problem hiding this comment.
Patch is fine and works. Interested in the response to my question - perhaps the comments could be a bit clearer. Let me know your thoughts.
| for file in os.listdir(cpu_stats_dir): | ||
| file_path = path.join(cpu_stats_dir, file) | ||
| if path.isfile(file_path) and file[0] != '.': | ||
| stat_files.append(file_path) |
There was a problem hiding this comment.
You could use glob in some form here. I.e. something like:
files = glob.glob(f'{archive-path}/logs/stats/cpu/*')
files += glob.glob(f'{archive-path}/*/logs/stats/cpu/*')
It's not needed - of course it's fine to add files one-at-a-time, but maybe if you're back changing this code later it's something you could think about.
2 participants
Logging + stats in cbbackupmgr has (mostly) been moved to the repository-level. This change makes promtimer compatible with these changes.