-
Notifications
You must be signed in to change notification settings - Fork 702
[feat][backend]Support workflow automation tasks #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/workflow_auto_task
…/workflow_auto_task
…/workflow_auto_task
# Conflicts: # backend/modules/observability/domain/task/service/taskexe/tracehub/scheduled_task.go
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (71.73%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 68.49% 68.50%
=======================================
Files 585 585
Lines 54190 54218 +28
=======================================
+ Hits 37120 37140 +20
- Misses 14233 14238 +5
- Partials 2837 2840 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
CozeLoop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary: Found a blocking type mismatch for TaskSource in DTO/DO convertors (compile-time error), plus an API design suggestion around ListTasks hard‑coded task_source filter. Please address the MUST FIX before merging.
MUST FIX:
- Convert TaskSource between *string and *task.TaskSource explicitly in application/convertor/task/task.go.
SUGGESTION:
- Only append default task_source filter when the client doesn’t specify it to keep API composability.
backend/modules/observability/application/convertor/task/task.go
Outdated
Show resolved
Hide resolved
backend/modules/observability/application/convertor/task/task.go
Outdated
Show resolved
Hide resolved
backend/modules/observability/domain/task/service/task_service.go
Outdated
Show resolved
Hide resolved
release/deployment/docker-compose/bootstrap/mysql-init/init-sql/task.sql
Show resolved
Hide resolved
release/deployment/helm-chart/charts/app/bootstrap/init/mysql/init-sql/task.sql
Show resolved
Hide resolved
# Conflicts: # backend/modules/observability/application/task.go # backend/modules/observability/domain/task/service/task_service.go # backend/modules/observability/domain/task/service/task_service_test.go
Change-Id: I4b0c25e42a83a09a51f13438aa72ec498eb0060b
Change-Id: Icbf52eabb5f2f2f1e4e1f84c3b2bdbb7f995bd88
Change-Id: Ic01c7cedbf7f702edb1560020eb3dd414ff18340
Change-Id: Ifee8c3cc566ec3b127511b1bf210b4fc0f520f77
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: