Skip to content

Conversation

@zero3233-bd
Copy link
Collaborator

@zero3233-bd zero3233-bd commented Oct 28, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 71.73913% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...y/domain/task/service/taskexe/tracehub/backfill.go 50.00% 3 Missing and 2 partials ⚠️
backend/modules/observability/application/task.go 76.47% 2 Missing and 2 partials ⚠️
...s/observability/application/convertor/task/task.go 66.66% 1 Missing and 1 partial ⚠️
.../observability/domain/task/service/task_service.go 91.66% 0 Missing and 1 partial ⚠️
...servability/infra/mq/producer/backfill_producer.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (71.73%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   68.49%   68.50%           
=======================================
  Files         585      585           
  Lines       54190    54218   +28     
=======================================
+ Hits        37120    37140   +20     
- Misses      14233    14238    +5     
- Partials     2837     2840    +3     
Flag Coverage Δ
unittests 68.50% <71.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...modules/observability/domain/task/entity/filter.go 0.00% <ø> (ø)
...d/modules/observability/domain/task/entity/task.go 47.00% <ø> (ø)
.../observability/domain/task/service/task_service.go 79.10% <91.66%> (+0.97%) ⬆️
...servability/infra/mq/producer/backfill_producer.go 0.00% <0.00%> (ø)
...s/observability/application/convertor/task/task.go 74.30% <66.66%> (-0.19%) ⬇️
backend/modules/observability/application/task.go 72.14% <76.47%> (+0.78%) ⬆️
...y/domain/task/service/taskexe/tracehub/backfill.go 65.46% <50.00%> (-1.32%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea6748...b6b5207. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: Found a blocking type mismatch for TaskSource in DTO/DO convertors (compile-time error), plus an API design suggestion around ListTasks hard‑coded task_source filter. Please address the MUST FIX before merging.

MUST FIX:

  • Convert TaskSource between *string and *task.TaskSource explicitly in application/convertor/task/task.go.

SUGGESTION:

  • Only append default task_source filter when the client doesn’t specify it to keep API composability.

zero3233-bd and others added 9 commits November 21, 2025 10:44
# Conflicts:
#	backend/modules/observability/application/task.go
#	backend/modules/observability/domain/task/service/task_service.go
#	backend/modules/observability/domain/task/service/task_service_test.go
Change-Id: I4b0c25e42a83a09a51f13438aa72ec498eb0060b
Change-Id: Icbf52eabb5f2f2f1e4e1f84c3b2bdbb7f995bd88
Change-Id: I7051a7bbbfa38a6daac1d1c264ff584b0b67bf61
Change-Id: I87c218444a096e2e0886ba474daa828c7516e12e
Change-Id: Ic01c7cedbf7f702edb1560020eb3dd414ff18340
Change-Id: I7bc1472d3c62677ce2c5ce3ec1b1baf448de073b
Change-Id: Ifee8c3cc566ec3b127511b1bf210b4fc0f520f77
Change-Id: I64f3c4368b0bca14ee0e4b622575e24906908473
taoyifan89
taoyifan89 previously approved these changes Nov 26, 2025
Change-Id: I79b30a2c5b0cf94230e8ece6cc9b2f9800d57633
@taoyifan89 taoyifan89 merged commit 90f6f7e into main Nov 26, 2025
12 checks passed
@taoyifan89 taoyifan89 deleted the dev/workflow_auto_task branch November 26, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants