Skip to content

Adding processElementIds to event #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

Adding processElementIds to event #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb1020
Adding processElementIds to event
kristiansp Sep 12, 2020
bb70ba1
Adding $processElementIds to the FeedProcesssEvent
kristiansp Sep 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/events/FeedProcessEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ class FeedProcessEvent extends CancelableEvent
public $feedData;
public $contentData;
public $element;
public $processedElementIds;
}
20 changes: 13 additions & 7 deletions src/services/Process.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,19 @@ public function afterProcessFeed($settings, $feed, $processedElementIds)
return;
}


// Fire an 'onProcessFeed' event
$event = new FeedProcessEvent([
'feed' => $feed,
'processedElementIds' => $processedElementIds,
]);

$this->trigger(self::EVENT_AFTER_PROCESS_FEED, $event);

// Allow event to modify variables
$feed = $event->feed;
$processedElementIds = $event->processedElementIds;

$elementsToDeleteDisable = array_diff($settings['existingElements'], $processedElementIds);

if ($elementsToDeleteDisable) {
Expand Down Expand Up @@ -513,13 +526,6 @@ public function afterProcessFeed($settings, $feed, $processedElementIds)
$message = 'Processing ' . count($processedElementIds) . ' elements finished in ' . $execution_time . 's';
Plugin::info($message);
Plugin::debug($message);

// Fire an 'onProcessFeed' event
$event = new FeedProcessEvent([
'feed' => $feed,
]);

$this->trigger(self::EVENT_AFTER_PROCESS_FEED, $event);
}

/**
Expand Down