fix linting warnings

Author: creativeprojects

fuse/mount.go

@@ -27,7 +27,7 @@ func MountFS(mountpoint string, files []File) (func(), error) {
 	if err != nil {
 		return nil, fmt.Errorf("failed to mount filesystem: %w", err)
 	}
-	close := func() {
+	closeFS := func() {
 		clog.Debug("unmounting filesystem")
 		err := server.Unmount() // don't need to call Wait after Unmount
 		if err != nil {
@@ -36,5 +36,5 @@ func MountFS(mountpoint string, files []File) (func(), error) {
 
 		memFS.Close()
 	}
-	return close, nil
+	return closeFS, nil
 }

remote.go

@@ -3,6 +3,7 @@ package main
 import (
 	"archive/tar"
 	"bytes"
+	"context"
 	"encoding/json"
 	"fmt"
 	"io"
@@ -22,7 +23,7 @@ func loadRemoteFiles(endpoint string) ([]fuse.File, *remote.Manifest, error) {
 	var parameters *remote.Manifest
 
 	client := http.DefaultClient
-	request, err := http.NewRequest("GET", endpoint, http.NoBody)
+	request, err := http.NewRequestWithContext(context.TODO(), http.MethodGet, endpoint, http.NoBody)
 	if err != nil {
 		return nil, nil, fmt.Errorf("failed to create request: %w", err)
 	}

send.go

@@ -37,7 +37,7 @@ func sendProfileCommand(w io.Writer, cmdCtx commandContext) error {
 		if err != nil {
 			resp.Header().Set("Content-Type", "text/plain")
 			resp.WriteHeader(http.StatusInternalServerError)
-			resp.Write([]byte(err.Error()))
+			_, _ = resp.Write([]byte(err.Error()))
 			return
 		}
 
@@ -46,8 +46,8 @@ func sendProfileCommand(w io.Writer, cmdCtx commandContext) error {
 
 		tar := remote.NewTar(resp)
 		defer tar.Close()
-		tar.SendFiles(afero.NewOsFs(), append(remoteConfig.SendFiles, remoteConfig.ConfigurationFile))
-		tar.SendFile(constants.ManifestFilename, manifestData)
+		_ = tar.SendFiles(afero.NewOsFs(), append(remoteConfig.SendFiles, remoteConfig.ConfigurationFile))
+		_ = tar.SendFile(constants.ManifestFilename, manifestData)
 	})
 	cnx := ssh.NewSSH(ssh.Config{
 		Host:           remoteConfig.Host,

serve.go

@@ -27,14 +27,14 @@ func serveCommand(w io.Writer, cmdCtx commandContext) error {
 		if !cmdCtx.config.HasRemote(remoteName) {
 			resp.Header().Set("Content-Type", "text/plain")
 			resp.WriteHeader(http.StatusNotFound)
-			resp.Write([]byte("remote not found"))
+			_, _ = resp.Write([]byte("remote not found"))
 			return
 		}
 		remoteConfig, err := cmdCtx.config.GetRemote(remoteName)
 		if err != nil {
 			resp.Header().Set("Content-Type", "text/plain")
 			resp.WriteHeader(http.StatusBadRequest)
-			resp.Write([]byte(err.Error()))
+			_, _ = resp.Write([]byte(err.Error()))
 			return
 		}
 
@@ -47,7 +47,7 @@ func serveCommand(w io.Writer, cmdCtx commandContext) error {
 		if err != nil {
 			resp.Header().Set("Content-Type", "text/plain")
 			resp.WriteHeader(http.StatusInternalServerError)
-			resp.Write([]byte(err.Error()))
+			_, _ = resp.Write([]byte(err.Error()))
 			return
 		}
 
@@ -57,8 +57,8 @@ func serveCommand(w io.Writer, cmdCtx commandContext) error {
 
 		tar := remote.NewTar(resp)
 		defer tar.Close()
-		tar.SendFiles(afero.NewOsFs(), append(remoteConfig.SendFiles, remoteConfig.ConfigurationFile))
-		tar.SendFile(constants.ManifestFilename, manifestData)
+		_ = tar.SendFiles(afero.NewOsFs(), append(remoteConfig.SendFiles, remoteConfig.ConfigurationFile))
+		_ = tar.SendFile(constants.ManifestFilename, manifestData)
 
 	})
 
@@ -67,8 +67,9 @@ func serveCommand(w io.Writer, cmdCtx commandContext) error {
 	defer signal.Stop(quit)
 
 	server := &http.Server{
-		Addr:    fmt.Sprintf("localhost:%s", cmdCtx.flags.resticArgs[1]),
-		Handler: handler,
+		Addr:              fmt.Sprintf("localhost:%s", cmdCtx.flags.resticArgs[1]),
+		Handler:           handler,
+		ReadHeaderTimeout: 5 * time.Second,
 	}
 
 	// put the shutdown code in a goroutine

ssh/ssh.go

@@ -76,7 +76,8 @@ func (s *SSH) Connect() error {
 
 	go func() {
 		s.server = &http.Server{
-			Handler: s.config.Handler,
+			Handler:           s.config.Handler,
+			ReadHeaderTimeout: 5 * time.Second,
 		}
 		// Serve HTTP with your SSH server acting as a reverse proxy.
 		err := s.server.Serve(s.tunnel)