From d6b8062014afbbe2a25523c73ee36fb07d1e172e Mon Sep 17 00:00:00 2001 From: Ezra Fein Date: Fri, 17 Apr 2020 17:49:11 -0400 Subject: [PATCH 1/2] Added discriminator to all nicks. The discriminator plays a crucial role: differentiating users with the same display name. Without this change, these users are indistinguishable, and direct messages to those users get confused for each other. --- server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server.js b/server.js index 36764de..9191e69 100644 --- a/server.js +++ b/server.js @@ -104,7 +104,7 @@ function ircNickname(discordDisplayName, botuser, discriminator) { return botuser ? `${newDisplayname}[BOT]` : newDisplayname; } else { - return botuser ? `${discordDisplayName}[BOT]` : discordDisplayName; + return botuser ? `${discordDisplayName}[BOT]` : `${discordDisplayName}${discriminator}`; } From 1ab1cb247f2274631096ebc765e6cdd10dc9015e Mon Sep 17 00:00:00 2001 From: Ezra Barrow <41446523+barrowsys@users.noreply.github.com> Date: Sat, 3 Oct 2020 20:28:06 -0400 Subject: [PATCH 2/2] Update server.js --- server.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server.js b/server.js index 9191e69..f513fb8 100644 --- a/server.js +++ b/server.js @@ -98,13 +98,13 @@ function ircNickname(discordDisplayName, botuser, discriminator) { if (replaceRegex.test(discordDisplayName)) { - let newDisplayname = `${discordDisplayName.replace(replaceRegex, '_')}${discriminator}`; + let newDisplayname = `${discordDisplayName.replace(replaceRegex, '_')}_${discriminator}`; newDisplayname = newDisplayname.replace(shortenRegex, '_'); return botuser ? `${newDisplayname}[BOT]` : newDisplayname; } else { - return botuser ? `${discordDisplayName}[BOT]` : `${discordDisplayName}${discriminator}`; + return botuser ? `${discordDisplayName}[BOT]` : `${discordDisplayName}_${discriminator}`; }