Apply some recomendations and update packages

cristofima · cristofima · commit 895a4d431ad7 · 2022-10-08T19:14:06.000-05:00
diff --git a/StoreCleanArchitecture.sln b/StoreCleanArchitecture.sln
@@ -19,7 +19,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Store.IntegrationTests", "t
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Store.SharedDatabaseSetup", "tests\Store.SharedDatabaseSetup\Store.SharedDatabaseSetup.csproj", "{3C31AD80-0F8C-4C04-B7B3-48CE53D7E508}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Store.FunctionalTests", "tests\Store.FunctionalTests\Store.FunctionalTests.csproj", "{959082E4-8E59-40AC-B4B1-D2BC22235DEB}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Store.FunctionalTests", "tests\Store.FunctionalTests\Store.FunctionalTests.csproj", "{959082E4-8E59-40AC-B4B1-D2BC22235DEB}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
diff --git a/src/Store.ApplicationCore/Exceptions/NotFoundException.cs b/src/Store.ApplicationCore/Exceptions/NotFoundException.cs
@@ -4,5 +4,16 @@ namespace Store.ApplicationCore.Exceptions
 {
     public class NotFoundException : Exception
     {
+        public NotFoundException() : base()
+        {
+        }
+
+        public NotFoundException(string message) : base(message)
+        {
+        }
+
+        public NotFoundException(string message, Exception innerException) : base(message, innerException)
+        {
+        }
     }
 }
diff --git a/src/Store.ApplicationCore/Utils/DateUtil.cs b/src/Store.ApplicationCore/Utils/DateUtil.cs
@@ -1,10 +1,8 @@
 ﻿using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Store.ApplicationCore.Utils
 {
-    public class DateUtil
+    public static class DateUtil
     {
         public static DateTime GetCurrentDate()
         {
diff --git a/src/Store.Infrastructure/Migrations/20211108211740_InitialCreate.cs b/src/Store.Infrastructure/Migrations/20211108211740_InitialCreate.cs
@@ -1,6 +1,6 @@
-﻿using System;
+﻿using Microsoft.EntityFrameworkCore.Migrations;
+using System;
 using System.Diagnostics.CodeAnalysis;
-using Microsoft.EntityFrameworkCore.Migrations;
 
 #nullable disable
 
diff --git a/src/Store.Infrastructure/Store.Infrastructure.csproj b/src/Store.Infrastructure/Store.Infrastructure.csproj
@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="6.0.8" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="6.0.9" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/src/Store.WebApi/Store.WebApi.csproj b/src/Store.WebApi/Store.WebApi.csproj
@@ -8,11 +8,11 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="6.0.8">
+    <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="6.0.9">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="6.0.8">
+    <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="6.0.9">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
diff --git a/tests/Store.FunctionalTests/Store.FunctionalTests.csproj b/tests/Store.FunctionalTests/Store.FunctionalTests.csproj
@@ -8,9 +8,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="6.0.8" />
-    <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="6.0.8" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.0" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="6.0.9" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="6.0.9" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
diff --git a/tests/Store.IntegrationTests/SharedDatabaseFixture.cs b/tests/Store.IntegrationTests/SharedDatabaseFixture.cs
@@ -12,7 +12,7 @@ public class SharedDatabaseFixture : IDisposable
         private static readonly object _lock = new object();
         private static bool _databaseInitialized;
 
-        private string dbName = "IntegrationTestsDatabase.db";
+        private readonly string dbName = "IntegrationTestsDatabase.db";
 
         public SharedDatabaseFixture()
         {
diff --git a/tests/Store.IntegrationTests/Store.IntegrationTests.csproj b/tests/Store.IntegrationTests/Store.IntegrationTests.csproj
@@ -8,8 +8,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="6.0.8" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.0" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="6.0.9" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
diff --git a/tests/Store.UnitTests/Store.UnitTests.csproj b/tests/Store.UnitTests/Store.UnitTests.csproj
@@ -8,7 +8,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,16 @@ namespace Store.ApplicationCore.Exceptions`
`4`	`4`	`{`
`5`	`5`	`public class NotFoundException : Exception`
`6`	`6`	`{`
	`7`	`+ public NotFoundException() : base()`
	`8`	`+ {`
	`9`	`+ }`
	`10`	`+`
	`11`	`+ public NotFoundException(string message) : base(message)`
	`12`	`+ {`
	`13`	`+ }`
	`14`	`+`
	`15`	`+ public NotFoundException(string message, Exception innerException) : base(message, innerException)`
	`16`	`+ {`
	`17`	`+ }`
`7`	`18`	`}`
`8`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,8 @@`
`1`	`1`	`using System;`
`2`		`-using System.Collections.Generic;`
`3`		`-using System.Text;`
`4`	`2`
`5`	`3`	`namespace Store.ApplicationCore.Utils`
`6`	`4`	`{`
`7`		`- public class DateUtil`
	`5`	`+ public static class DateUtil`
`8`	`6`	`{`
`9`	`7`	`public static DateTime GetCurrentDate()`
`10`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public class SharedDatabaseFixture : IDisposable`
`12`	`12`	`private static readonly object _lock = new object();`
`13`	`13`	`private static bool _databaseInitialized;`
`14`	`14`
`15`		`- private string dbName = "IntegrationTestsDatabase.db";`
	`15`	`+ private readonly string dbName = "IntegrationTestsDatabase.db";`
`16`	`16`
`17`	`17`	`public SharedDatabaseFixture()`
`18`	`18`	`{`