perf(jfr-datasource): refactor to perform uploads using streams #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
changed the title
andrewazores
force-pushed
the
grafana-upload-streams
branch
from
03d6479 to
ca24167
Compare
|
This PR/issue depends on:
|
andrewazores
changed the title
Member
Author
|
/build_test |
|
Workflow started at 11/18/2025, 12:33:20 PM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ |
andrewazores
force-pushed
the
grafana-upload-streams
branch
from
ca24167 to
347c819
Compare
Member
Author
|
/build_test |
|
Workflow started at 11/28/2025, 10:30:30 AM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ |
Josh-Matsuoka
approved these changes
Dec 1, 2025
andrewazores
force-pushed
the
grafana-upload-streams
branch
from
347c819 to
e4f511e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainSee #1151
Based on #1151
Description of the change:
Avoid the old flow of copying recording file contents to a local temp file before POSTing to jfr-datasource. For archived recordings when not using presigned URL transfers this would involve Cryostat downloading the archived JFR file from storage into a temp file, then POSTing that file. For active recordings Cryostat would open a remote target connection and stream the recording contents into a temp file, then POST that file. The new flow avoids writing a temp file and uses streamed data instead - either the HTTP GET response stream from storage, or the target connection recording data stream, and sends the POST to jfr-datasource by directly piping that stream.
Motivation for the change:
Avoid the need for Cryostat's tmp space to be able to accommodate arbitrarily large JFR file data. This also reduces overall "view in Grafana" action request latency since the data does not need to be fully written to tmp file before beginning to upload it to the datasource.
How to manually test:
./smoketest.bash -O -t quarkus-cryostat-agent