Rust Engine: bridge from rust #1550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
force-pushed
the
rengine-bridge-from-rust-idenpendent
branch
2 times, most recently
from
635add3 to
901996e
Compare
Member
Author
|
This need some rebasing |
Member
Author
|
I'm rebasing that one now |
W95Psp
force-pushed
the
rengine-bridge-from-rust-idenpendent
branch
from
74a7891 to
1889a33
Compare
Member
Author
Member
Author
|
I'm looking at that PR again now |
Member
Author
|
Closing that one in favor of #1755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bridge from the AST of the Rust engine back to the AST of the OCaml engine.
It also fixes up a few nodes of the AST that were superfluous or were lacking informations.
This PR doesn't do anything with the bridge itself for now.
This PR also change slightly how names are represented: instead of using concrete identifiers for tuples, we now have dedicated nodes. This will be much easier to match on tuples of arbirary sizes.
That last change probably breaks the output of Lean @clementblaudeau, I will fix it soon.So this PR is not ready to be merged, but can be reviewed.Fixes #1578.