Bugfix/reactforrole (#124)

* bugfix and remove react_role_roles table

* run prettier

* changed let to var

* removed multiple declarations of variable

* prettier

* change var back to let

* change let to var

* prettier

* remove code to delete existing schema from db

* change var back to let

* prettier

Author: EmilyyyL

commands/reactforrole.js

@@ -36,8 +36,8 @@ module.exports = {
 
         const emojis = interaction.options.getString("emojis");
         const roleNames = interaction.options.getString("rolenames");
-        /* eslint-disable */
-        var message = interaction.options.getString("message");
+
+        let message = interaction.options.getString("message");
 
         const emojiList = emojis.split(",").map((item) => item.trim());
         const roleList = roleNames.split(",").map((item) => item.trim());
@@ -76,20 +76,19 @@ module.exports = {
 
         const roles = {};
 
-        var notificationContent = "This command: \n"; /* eslint-disable */
+        let notificationContent = "This command: \n";
 
-        for (var i = 0; i < roleList.length; i++) {
-            /* eslint-disable */
+        for (let i = 0; i < roleList.length; i++) {
             const roleName = roleList[i];
-            var emoji = emojiList[i]; /* eslint-disable */
+            let emoji = emojiList[i];
 
             if (custom_emoji_regex.test(emoji)) {
                 emoji = emoji.split(":")[1];
             }
 
             // Check if role exist
             const role = interaction.member.guild.roles.cache.find((r) => r.name === roleName);
-            var roleID = 0; /* eslint-disable */
+            let roleID = 0;
 
             if (role) {
                 const roleIsAdmin = role.permissions.has("ADMINISTRATOR");
@@ -130,8 +129,7 @@ module.exports = {
 
         message += "React to give yourself a role";
 
-        for (var j = 0; j < emojiList.length; j++) {
-            /* eslint-disable */
+        for (let j = 0; j < emojiList.length; j++) {
             message += `\n${emojiList[j]}: ${roleList[j]}`;
         }
 

lib/database/dbreactrole.js

@@ -25,20 +25,6 @@ class DBReactRole {
             const has_roles_table = await this.check_table("react_role_roles");
             if (has_roles_table == false) {
                 await this.create_react_role_roles_table();
-            } else {
-                const client = await this.pool.connect();
-                try {
-                    console.log("Running deleting old ");
-                    await client.query("BEGIN");
-                    await client.query(`DROP TABLE REACT_ROLE_ROLES`);
-                    await client.query("COMMIT");
-                } catch (ex) {
-                    console.log(`Something wrong happend in react role ${ex}`);
-                } finally {
-                    await client.query("ROLLBACK");
-                    client.release();
-                }
-                await this.create_react_role_roles_table();
             }
         })();
     }