Skip to content

Return value when Phone contains alpha chars instead of attempting formatting #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstegelman merged 2 commits into from
Jan 27, 2026
Merged

Return value when Phone contains alpha chars instead of attempting formatting #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cad53fc
Return value when Phone contains alpha chars instead of attempting fo…
dstegelman Jan 27, 2026
e1571cd
Fix test error
dstegelman Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CsuChhs.Extensions.Tests/StringExtensionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ public void TestCsvString()
Assert.Equal("string; with; some; commas; apostrophes and double quotes ", stringWithCommas.ToCsvString());
}

[Fact]
public void TestFormattedPhoneWithChars()
{
Assert.Equal("844LMENBRO", "844LMENBRO".ToPhoneNumber());
}

[Fact]
public void TestFormattedPhoneSevenDigits()
{
Expand Down
2 changes: 1 addition & 1 deletion CsuChhs.Extensions/CsuChhs.Extensions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Nullable>enable</Nullable>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Authors>CHHS Application Development Team</Authors>
<Version>1.5.5</Version>
<Version>1.5.6</Version>
<PackageProjectUrl>https://github.com/csu-chhs/CsuChhs.Extensions</PackageProjectUrl>
<Company>College of Health and Human Sciences</Company>
<PackageId>CsuChhs.Extensions</PackageId>
Expand Down
7 changes: 7 additions & 0 deletions CsuChhs.Extensions/StringExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,13 @@ public static string ToPhoneNumber(this string value)
.Replace(")", "")
.Replace("-", "");

// If after we replace chars, we still do not have
// only numbers, return the value.
if(!IsNumeric(phone))
{
return phone;
}

switch (phone.Length)
{
case 7:
Expand Down