csgrep --warning-rate-limit: fix msg of the note event

The code used a string that was already overwritten for the error event.

Closes: #121

Author: kdudka

src/lib/filter.cc

@@ -262,27 +262,28 @@ void RateLimitter::flush()
 {
     for (; !d->errors.empty(); d->errors.pop()) {
         Defect &def = d->errors.front();
+        DefEvent &evtErr = def.events.back();
+
+        // make a copy now because evtErr.event will be overwritten
+        DefEvent evtNote = evtErr;
 
         // resolve the count of occurrences for this checker/event pair
-        const DefEvent &keyEvt = def.events[def.keyEventIdx];
-        const Private::TKey key(def.checker, keyEvt.event);
+        const Private::TKey key(def.checker, evtErr.event);
         const Private::TCnt cnt = d->counter[key];
 
-        // construct an error event
+        // construct an error event in-place
         std::ostringstream err, note;
-        err << cnt << " occurrences of " << keyEvt.event
-            << " exceeded the specified limit "
+        err << cnt << " occurrences of "
+            << evtErr.event << " exceeded the specified limit "
             << d->rateLimit;
 
-        DefEvent &evtErr = def.events.back();
         evtErr.event = "error[too-many]";
         evtErr.msg = err.str();
 
         // construct a note event
         note << (cnt - d->rateLimit) << " occurrences of "
-            << keyEvt.event << " were discarded because of this";
+            << evtNote.event << " were discarded because of this";
 
-        DefEvent evtNote = evtErr;
         evtNote.event = "note";
         evtNote.msg = note.str();
         evtNote.verbosityLevel = /* info */ 1;

tests/csgrep/0110-warning-rate-limit-stdout.txt

@@ -1892,7 +1892,7 @@
                     "line": 3,
                     "column": 8,
                     "event": "note",
-                    "message": "99 occurrences of error[too-many] were discarded because of this",
+                    "message": "99 occurrences of note[SC2086] were discarded because of this",
                     "verbosity_level": 1
                 }
             ]
@@ -1917,7 +1917,7 @@
                     "line": 128,
                     "column": 37,
                     "event": "note",
-                    "message": "13 occurrences of error[too-many] were discarded because of this",
+                    "message": "13 occurrences of warning[SC2207] were discarded because of this",
                     "verbosity_level": 1
                 }
             ]

tests/csgrep/sync.sh

@@ -2,7 +2,7 @@
 set -exo pipefail
 
 # set path to project root
-PROJECT_ROOT="../../"
+PROJECT_ROOT="../.."
 
 # import ${JSFILTER_CMD}
 . ../test-lib.sh