Merge pull request #813 from cucumber/cucumber-messages/use-pure-ruby-protobuf

cucumber-messages: Use pure-Ruby protobuf implementation (experimental)

Author: aslakhellesoy

.circleci/config.yml

@@ -14,7 +14,7 @@ executors:
     docker:
       # Remember to update to the latest image tag.
       # Run `source scripts/functions.sh && docker_image Dockerfile` to print it.
-      - image: cucumber/cucumber-build:9ce5f6a542de12ceecdd84caaad47365
+      - image: cucumber/cucumber-build:7e07f786ac72e3597a8e5bbe435b4c90
     working_directory: ~/cucumber
   # Go
   docker-circleci-golang:
@@ -397,7 +397,7 @@ jobs:
       - persist_to_workspace:
           root: ~/cucumber
           paths:
-            - cucumber-messages/ruby/lib/cucumber/messages_pb.rb
+            - cucumber-messages/ruby
 
   gherkin-ruby-23:
     executor: docker-circleci-ruby-23

.templates/ruby/Rakefile

@@ -5,6 +5,10 @@ Bundler::GemHelper.install_tasks
 
 $:.unshift File.expand_path("../lib", __FILE__)
 
+Dir['./rake/*.rb'].each do |f|
+  require f
+end
+
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.ruby_opts  = %w[-r./spec/coverage -w]

Dockerfile

@@ -32,6 +32,7 @@ RUN apk add --no-cache \
   py2-pip \
   rsync \
   ruby \
+  ruby-bigdecimal \
   ruby-dev \
   sed \
   su-exec \

c21e/ruby/Rakefile

@@ -5,6 +5,10 @@ Bundler::GemHelper.install_tasks
 
 $:.unshift File.expand_path("../lib", __FILE__)
 
+Dir['./rake/*.rb'].each do |f|
+  require f
+end
+
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.ruby_opts  = %w[-r./spec/coverage -w]

cucumber-demo-formatter/ruby/Rakefile

@@ -5,6 +5,10 @@ Bundler::GemHelper.install_tasks
 
 $:.unshift File.expand_path("../lib", __FILE__)
 
+Dir['./rake/*.rb'].each do |f|
+  require f
+end
+
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.ruby_opts  = %w[-r./spec/coverage -w]

cucumber-demo-formatter/ruby/bin/cucumber-demo-formatter

@@ -8,7 +8,7 @@ require 'cucumber_demo_formatter'
 ARGV << '-h' if ARGV.empty?
 
 option_parser = OptionParser.new do |opts|
-  opts.on '-f', '--format=ndjson|protobuf', 'Output format'
+  opts.on '-f', '--format=ndjson|protobuf', 'Input format'
 
   opts.on_tail("-h", "--help", "Show this message") do
     puts opts
@@ -29,4 +29,4 @@ else
   raise "Unsupported format: '#{format}'"
 end
 
-formatter.process_messages(message_enumerator, STDOUT)
+formatter.process_messages(message_enumerator, STDOUT)

cucumber-demo-formatter/ruby/lib/cucumber_demo_formatter.rb

@@ -3,21 +3,24 @@
 class CucumberDemoFormatter
   def process_messages(message_enumerator, output)
     emoji = {
-      UNKNOWN:   '👽',
-      PASSED:    '😃',
-      SKIPPED:   '🥶',
-      PENDING:   '⏰',
-      UNDEFINED: '🤷',
-      AMBIGUOUS: '🦄',
-      FAILED:    '💣',
+      ::Cucumber::Messages::TestResult::Status::UNKNOWN   => '👽',
+      ::Cucumber::Messages::TestResult::Status::PASSED    => '😃',
+      ::Cucumber::Messages::TestResult::Status::SKIPPED   => '🥶',
+      ::Cucumber::Messages::TestResult::Status::PENDING   => '⏰',
+      ::Cucumber::Messages::TestResult::Status::UNDEFINED => '🤷',
+      ::Cucumber::Messages::TestResult::Status::AMBIGUOUS => '🦄',
+      ::Cucumber::Messages::TestResult::Status::FAILED    => '💣',
     }
     message_enumerator.each do |message|
       if message.test_step_finished
-        output.write(emoji[message.test_step_finished.test_result.status])
+        status = message.test_step_finished.test_result.status
+        em = emoji[status]
+        raise "No emoji found for status #{status}" if em.nil?
+        output.write(em)
       end
       if message.test_run_finished
         output.write("\n")
       end
     end
   end
-end
+end

cucumber-expressions/ruby/Rakefile

@@ -5,6 +5,10 @@ Bundler::GemHelper.install_tasks
 
 $:.unshift File.expand_path("../lib", __FILE__)
 
+Dir['./rake/*.rb'].each do |f|
+  require f
+end
+
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.ruby_opts  = %w[-r./spec/coverage -w]

cucumber-json-formatter/ruby/Rakefile

@@ -5,6 +5,10 @@ Bundler::GemHelper.install_tasks
 
 $:.unshift File.expand_path("../lib", __FILE__)
 
+Dir['./rake/*.rb'].each do |f|
+  require f
+end
+
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.ruby_opts  = %w[-r./spec/coverage -w]

cucumber-messages/dotnet/messages.proto

@@ -1,6 +1,5 @@
 syntax = "proto3";
 package io.cucumber.messages;
-option ruby_package = "Cucumber::Messages";
 option go_package = "messages";
 
 // When removing a field, replace it with reserved, rather than deleting the line.
@@ -426,13 +425,13 @@ message TestCase {
     string pickle_step_id = 2;
     // Pointer to all the matching `StepDefinition`s (if derived from a PickleStep)
     repeated string step_definition_ids = 3;
-    // A list of list of StepMatchArgument (if derived from a `StepDefinition`). 
+    // A list of list of StepMatchArgument (if derived from a `StepDefinition`).
     // Each element represents a matching step definition. A size of 0 means `UNDEFINED`,
     // and a size of 2+ means `AMBIGUOUS`
     repeated StepMatchArgumentsList step_match_arguments_lists = 4;
     // Pointer to the `Hook` (if derived from a Hook)
     string hook_id = 5;
-    
+
     message StepMatchArgumentsList {
       repeated StepMatchArgument step_match_arguments = 1;
     }