Add support for minimum-strength requirements and new blocklist configurations. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing. Turned off no implicit any for typescript compiler since I couldn't get bloom-filter-js working otherwise.
…verywhere (10^12 = 2/3 meter full)
…ic-password modal (clicking 'Why?' for specific recommendations). Also fixed bug related to lack of discardpw() function in ui module (this did not seem to affect functionality, but gets rid of javascript error)
… meter feedback. Also added option for specifying whether concrete password suggestions are generated/provided by the meter.
…-enhancement, in the case when a user modifies their password in the modal but then chooses to discard that password when returning to the main meter password box.
…s can be located (for use with Django).
…d heuristic log guess number back as event data.
…ere used, with pointers to original source.
…ds before feedback about unmet min-strength requirements.
Collaborator
|
Hi Josh, There were important updates that are in my branch that never went into the cupslab repo. I will see about putting together a three-sided merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code under example/ can be seen running here: https://cups.cs.cmu.edu/meter2/