Fix potential AttributeError in session cleanup #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
_close()method inClientBasewas attempting to call.close()onself._current_sessionwithout checking if it wasNonefirst. This could lead to anAttributeErrorwhen:use_connection_pooling=False)NoneSolution
Added a null check to the condition in
_close()method to ensure we only attempt to close the session if it actually exists: