Crash

[kloetzl]

Hi,

I found an interesting crash; The given zip contains two trees. If you execute them in the following order:

cat S22EC_83_Contigs.tree andi.tree | rspr

rspr breaks, but the other way round it works just fine. Hope you can make sense of it.

Trees: rspr_crash.zip

[cwhidden]

These appear to be unrooted trees so you will have to use some of the unrooted options. If you are just looking for the distance then you can use the options "-total -unrooted". If you want the agreement forest then you need to use the included perl script "gen_rooted_trees.pl" to generate all rootings of the trees and compare each rooting of the first tree to each rooting of the second tree with the option "-unrooted".

The trees also seem a bit weird with values of 0:0.00x on the interior nodes. The value before the colon caused some problems with some scripts that I used to look at these trees (but not rspr).

Please keep in mind that rspr is designed for the rooted SPR distance. These unrooted options will compare different rootings of the trees to each other but still solve the rooted SPR distance problem. I also have software https://github.com/cwhidden/uspr for unrooted trees, but that is a more difficult problem and the software not as optimized so I am unsure how long it will take on the trees you provided. If you want to try uspr then you will have to strip out those leading 0's before the colons.

[kloetzl]

The leading zeros are missing support values, I should get rid of them. You are absolutely right about the rootedness/flags. I should fix that.

Still, I am very surprised that the distance works with the trees given in one order, but crashed with the other.