Update batch.R - Sets the maximum time (in seconds) to wait while try… #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to connect to the server.
Contributor
Author
Robinlovelace
approved these changes
Dec 3, 2024
Collaborator
|
Let's see if the tests pass, will merge if so! |
Robinlovelace
requested changes
Dec 3, 2024
Collaborator
Robinlovelace
left a comment
Robinlovelace
left a comment
There was a problem hiding this comment.
Tests not passing:
** using staged installation
** R
Error in parse(...) :
/home/runner/work/cyclestreets-r/cyclestreets-r/check/cyclestreets.Rcheck/00_pkg_src/cyclestreets/R/batch.R:310:3: unexpected symbol
309: res = httr::POST(url = batch_url, body = body, httr::timeout(60*60*5), httr::config(connecttimeout = 60 * 60 * 5) # Connection timeout (5 hours))
310: res_json
^
ERROR: unable to collate and parse R files for package ‘cyclestreets’
* removing ‘/home/runner/work/cyclestreets-r/cyclestreets-r/check/cyclestreets.Rcheck/cyclestreets’
Have you tried devtools::check() @wangzhao0217 ?
Contributor
Author
|
close with a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the maximum time (in seconds) to wait while trying to connect to the server. This only limits the connection phase, not the entire request.
By adding httr::config(connecttimeout = 60 * 60 * 5), allowing the connection phase to take up to 5 hours, matching overall timeout.