Only show latest state tasks for workflows, not workflow dirs/groups

We cannot show the true latest tasks for groups, and it is unclear what workflow each task belongs to

Author: MetRonnie

src/components/cylc/TaskStateBadge.vue

@@ -26,11 +26,11 @@
       :open-delay="400"
     >
       {{ value }} {{ displayName }} task{{ value > 1 ? 's': '' }}.
-      <template v-if="latestTasks.length">
+      <template v-if="latestTasks?.length">
         Latest:
         <span
-          v-for="(task, index) in latestTasks.slice(0, maxLatestTasks)"
-          :key="index"
+          v-for="task in latestTasks"
+          :key="task"
           class="text-grey-lighten-1"
         >
           <br/>{{ task }}
@@ -56,10 +56,6 @@ const props = defineProps({
     type: Array,
     default: () => [],
   },
-  maxLatestTasks: {
-    type: Number,
-    default: 5,
-  },
 })
 
 const displayName = computed(

src/components/cylc/tree/GScanTreeItem.vue

@@ -99,11 +99,13 @@ const taskStatesOrdered = [
 /**
  * Get aggregated task state totals for all descendents of a node.
  *
+ * Also get latest state tasks for workflow nodes.
+ *
  * @param {Object} node
  * @param {Record<string, number>} stateTotals - Accumulator for state totals.
- * @param {Record<string, string[]>} latestTasks - Accumulator for latest tasks.
  */
-function getStatesInfo (node, stateTotals = {}, latestTasks = {}) {
+function getStatesInfo (node, stateTotals = {}) {
+  const latestTasks = {}
   // if we aren't at the end of the node tree, continue recurse until we hit something other then a workflow part
   if (node.type === 'workflow-part' && node.children) {
     // at every branch, recurse all child nodes except stopped workflows
@@ -118,19 +120,19 @@ function getStatesInfo (node, stateTotals = {}, latestTasks = {}) {
     // the non-zero state totals from this node with all the others from the tree
     for (const state of taskStatesOrdered) {
       let nodeTotal = node.node.stateTotals[state]
-      const nodeLatestTasks = Array.from(node.node.latestStateTasks?.[state] ?? [])
+      let nodeLatestTasks = node.node.latestStateTasks?.[state] ?? []
       if (state === TaskState.SUBMITTED.name) { // include preparing tasks
         nodeTotal += node.node.stateTotals.preparing
-        nodeLatestTasks.push(...(node.node.latestStateTasks?.preparing ?? []))
+        nodeLatestTasks = [
+          ...nodeLatestTasks,
+          ...(node.node.latestStateTasks?.preparing ?? []),
+        ].slice(0, 5) // limit to 5 latest (submitted tasks take priority)
       }
       if (nodeTotal) {
         stateTotals[state] = (stateTotals[state] ?? 0) + nodeTotal
       }
       if (nodeLatestTasks.length) {
-        latestTasks[state] = [
-          ...(latestTasks[state] ?? []),
-          ...nodeLatestTasks,
-        ].sort().reverse() // cycle point descending order
+        latestTasks[state] = nodeLatestTasks
       }
     }
   }

tests/unit/components/cylc/tree/treeitem.vue.spec.js

@@ -151,9 +151,8 @@ describe('GScanTreeItem', () => {
         filteredOutNodesCache: new WeakMap(),
       }
     })
-    it('combines all descendant tasks', () => {
-      expect(wrapper.vm.statesInfo.latestTasks.submitted.length).to.equal(20)
-      expect(wrapper.vm.statesInfo.latestTasks.running.length).to.equal(10)
+    it('does not combine descendant latest state tasks', () => {
+      expect(wrapper.vm.statesInfo.latestTasks).to.deep.equal({})
     })
     it('combines all descendant task totals', () => {
       expect(wrapper.vm.statesInfo.stateTotals.submitted).to.equal(5)