From 2d3f25e57fe5010222b67ccde9a7676878209a11 Mon Sep 17 00:00:00 2001 From: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Date: Mon, 6 Oct 2025 14:56:40 +0100 Subject: [PATCH 01/10] Fix hit area of task/job icons --- src/components/cylc/table/Table.vue | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/components/cylc/table/Table.vue b/src/components/cylc/table/Table.vue index 3f66c3ff1..87df61e4a 100644 --- a/src/components/cylc/table/Table.vue +++ b/src/components/cylc/table/Table.vue @@ -33,14 +33,14 @@ along with this program. If not, see . :class="{ 'flow-none': isFlowNone(item.task.node.flowNums) }" :data-cy-task-name="item.task.name" > -
+
-
+
. >
-
+
- #{{ job.node.submitNum }}
+ #{{ job.node.submitNum }}
{{ job.node.platform }} @@ -288,6 +288,11 @@ const taskRunTimes = computed(() => new Map( ]) )) +const jobIconParentProps = { + class: ['d-flex', 'align-center'], + style: { width: '2em' }, +} + const itemsPerPageOptions = [ { value: 10, title: '10' }, { value: 20, title: '20' }, From ddbbb1abf9559bcbbdfb3327b0753d7a4a29c0bb Mon Sep 17 00:00:00 2001 From: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Date: Mon, 6 Oct 2025 15:00:05 +0100 Subject: [PATCH 02/10] Replace task state icons with badges in sidebar --- src/components/cylc/TaskStateBadge.vue | 45 ++++++ src/components/cylc/WarningIcon.vue | 4 +- src/components/cylc/tree/GScanTreeItem.vue | 57 ++----- src/components/cylc/workspace/Toolbar.vue | 2 +- src/styles/cylc/_job.scss | 172 ++++++++------------- tests/e2e/specs/userprofile.cy.js | 16 +- 6 files changed, 137 insertions(+), 159 deletions(-) create mode 100644 src/components/cylc/TaskStateBadge.vue diff --git a/src/components/cylc/TaskStateBadge.vue b/src/components/cylc/TaskStateBadge.vue new file mode 100644 index 000000000..d5efc3fda --- /dev/null +++ b/src/components/cylc/TaskStateBadge.vue @@ -0,0 +1,45 @@ + + + + + diff --git a/src/components/cylc/WarningIcon.vue b/src/components/cylc/WarningIcon.vue index 51eeeb6f3..ef06b6013 100644 --- a/src/components/cylc/WarningIcon.vue +++ b/src/components/cylc/WarningIcon.vue @@ -26,9 +26,8 @@ along with this program. If not, see . diff --git a/src/components/cylc/tree/GScanTreeItem.vue b/src/components/cylc/tree/GScanTreeItem.vue index e2112828b..1acd495bd 100644 --- a/src/components/cylc/tree/GScanTreeItem.vue +++ b/src/components/cylc/tree/GScanTreeItem.vue @@ -18,7 +18,7 @@ along with this program. If not, see . - diff --git a/src/services/mock/json/workflows/one.json b/src/services/mock/json/workflows/one.json index 49273f25a..784b2ac56 100644 --- a/src/services/mock/json/workflows/one.json +++ b/src/services/mock/json/workflows/one.json @@ -23,14 +23,14 @@ "latestStateTasks": { "submitted": [], "running": [ - "checkpoint" + "20000102T0000Z/checkpoint" ], "succeeded": [ - "eventually_succeeded", - "succeeded" + "20000102T0000Z/eventually_succeeded", + "20000102T0000Z/succeeded" ], "failed": [ - "failed" + "20000102T0000Z/failed" ] } }, diff --git a/tests/unit/components/cylc/tree/treeitem.vue.spec.js b/tests/unit/components/cylc/tree/treeitem.vue.spec.js index 168f94277..3a3c0cf70 100644 --- a/tests/unit/components/cylc/tree/treeitem.vue.spec.js +++ b/tests/unit/components/cylc/tree/treeitem.vue.spec.js @@ -152,12 +152,12 @@ describe('GScanTreeItem', () => { } }) it('combines all descendant tasks', () => { - expect(wrapper.vm.descendantTaskInfo.latestTasks.submitted.length).to.equal(10) - expect(wrapper.vm.descendantTaskInfo.latestTasks.running.length).to.equal(10) + expect(wrapper.vm.statesInfo.latestTasks.submitted.length).to.equal(10) + expect(wrapper.vm.statesInfo.latestTasks.running.length).to.equal(10) }) it('combines all descendant task totals', () => { - expect(wrapper.vm.descendantTaskInfo.stateTotals.submitted).to.equal(5) - expect(wrapper.vm.descendantTaskInfo.stateTotals.running).to.equal(12) + expect(wrapper.vm.statesInfo.stateTotals.submitted).to.equal(5) + expect(wrapper.vm.statesInfo.stateTotals.running).to.equal(12) }) it('collapses to the lowest only-child', () => { expect(wrapper.vm.node.id).to.equal('~cylc/double/mid') From 266038f5ea41519090e7b32a338934975a188dab Mon Sep 17 00:00:00 2001 From: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Date: Wed, 5 Nov 2025 17:37:28 +0000 Subject: [PATCH 08/10] Include preparing tasks in submitted task state badge total --- src/components/cylc/TaskStateBadge.vue | 10 ++++++++-- src/components/cylc/tree/GScanTreeItem.vue | 10 +++++++--- tests/unit/components/cylc/tree/treeitem.vue.spec.js | 2 +- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/src/components/cylc/TaskStateBadge.vue b/src/components/cylc/TaskStateBadge.vue index 8aadc322e..2283b0357 100644 --- a/src/components/cylc/TaskStateBadge.vue +++ b/src/components/cylc/TaskStateBadge.vue @@ -25,7 +25,7 @@ location="top" :open-delay="400" > - {{ value }} {{ state }} task{{ value > 1 ? 's': '' }}. + {{ value }} {{ displayName }} task{{ value > 1 ? 's': '' }}.