Upgrade Cylc Review to Python 3

Author: wxtim

.github/workflows/test.yml

@@ -58,13 +58,21 @@ jobs:
         with:
           cylc_flow: true
           cylc_flow_opts: ''
+          editable_installations: true
+
+      - name: bodge
+        run: |
+          # This is a bodge to make this branch work before companion branches
+          # merged:
+          pip install -e git+https://github.com/wxtim/cylc@feat.cylc-review#egg=cylc-flow --no-deps
 
       - name: install cylc-uiserver
-        run: pip install -e .[all]
+        run: |
+          pip install -e .[all]
 
       - name: Style test
         if: startsWith(matrix.os, 'ubuntu')
-        run: flake8
+        run: flake8 cylc/uiserver/* tests/unit/* tests/integration/*
 
       - name: Type checking
         if: startsWith(matrix.os, 'ubuntu')
@@ -76,8 +84,36 @@ jobs:
       - name: Test
         run: pytest
 
+      - name: Cylc Review tests
+        run: |
+          CONF_PATH="$HOME/.cylc/flow/8"
+          mkdir -p "$CONF_PATH"
+          touch "$CONF_PATH/global.cylc"
+          ln -s "$CONF_PATH/global.cylc" "$CONF_PATH/global-tests.cylc"
+
+          cat >> "$CONF_PATH/global.cylc" <<__HERE__
+          [platforms]
+            [[_local_background_indep_tcp]]
+              hosts = localhost
+              install target = localhost
+              ssh command = ssh -oBatchMode=yes -oConnectTimeout=8 -oStrictHostKeyChecking=no
+          __HERE__
+
+          # Check that Cylc Review is ready to run
+          # (We're only interested if it emits an error):
+          cylc review --help > /dev/null || exit 1
+
+          # Run tests on Cylc Review
+          export CYLC_COVERAGE=1
+          ./etc/bin/run-functional-tests
+
       - name: Coverage report
         run: |
+          echo pwd:
+          pwd
+          echo ls:
+          ls
+          coverage combine --append src/cylc-flow
           coverage xml --ignore-errors
           coverage report
 

cylc/uiserver/cylc_review/template/index.html

@@ -15,6 +15,9 @@
 {% if logo -%}
 <img {{logo}} />
 {% endif -%}
+{% if jupythub_base %}
+<a href="{{jupythub_base}}">Return to Cylc GUI</a>
+{% endif %}
 <h1>{{title}} <small>@ {{host}}</small></h1>
 <p>Browse User Suite-logs on HTTP</p>
 <p class="pull-right"><small>Cylc {{cylc_version}}</small></p>

cylc/uiserver/cylc_review/template/suite-base.html

@@ -29,6 +29,11 @@
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
       </button>
+
+      {% if jupythub_base %}
+      <a class="navbar-brand" href="{{jupythub_base}}">Cylc GUI</a>
+      <div class="navbar-brand">|</div>
+      {% endif %}
       <a class="navbar-brand" href="{{script}}/">
         {% if logo -%}
         <img {{logo}} />

cylc/uiserver/cylc_review/template/suites.html

@@ -24,6 +24,10 @@
         <span class="icon-bar"></span>
         <span class="icon-bar"></span>
       </button>
+      {% if jupythub_base %}
+      <a class="navbar-brand" href="{{jupythub_base}}">Cylc GUI</a>
+      <div class="navbar-brand">|</div>
+      {% endif %}
       <a class="navbar-brand" href="{{script}}/">
         {% if logo -%}
         <img {{logo}} />

cylc/uiserver/jupyter_config.py

@@ -24,6 +24,7 @@
 )
 from cylc.uiserver.app import USER_CONF_ROOT
 from cylc.uiserver.authorise import CylcAuthorizer
+from cylc.uiserver.ws import get_review_service_config
 
 
 # the command the hub should spawn (i.e. the cylc uiserver itself)
@@ -104,3 +105,7 @@
 # Lab as a result of being granted the ``access:servers`` permission in Jupyter
 # Hub.
 c.ServerApp.authorizer_class = CylcAuthorizer
+
+
+# Setup Cylc Review
+c.JupyterHub.services = [get_review_service_config()]